[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gameoftrees
Subject:    Re: build with -Wmissing-prototypes
From:       Stefan Sperling <stsp () stsp ! name>
Date:       2022-06-25 9:04:40
Message-ID: YrbPqHsVJ3NsbEGj () camille ! stsp ! name
[Download RAW message or body]

On Sat, Jun 25, 2022 at 10:00:39AM +0200, Omar Polo wrote:
> Omar Polo <op@omarpolo.com> wrote:
> > as per title, what about if we build got with -Wmissing-prototypes?
> > Its purpose is to emit a warning when the compiler sees a non-static
> > function without having seen a corresponding prototype first.
> > 
> > The bulk of the diff is just adding `static' to local functions or add
> > missing include, but note that it also catched an unused function
> > got_path_is_current_dir.  (it was introduced in a129376 and never used)
> > 
> > thoughts?
> 
> I forgot about regress, updated diff.

Yes, seems like a good idea to me, given how many errors 
in our use of 'static' this has uncovered.

And since we're only using these flags in non-release builds
there should be no problems for packagers because of this.

ok



[prev in list] [next in list] [prev in thread] [next in thread]