[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gameoftrees
Subject:    Re: fix staging of multiple files with -p
From:       Stefan Sperling <stsp () stsp ! name>
Date:       2019-10-28 10:32:57
Message-ID: 20191028103257.GC11903 () ted ! stsp ! name
[Download RAW message or body]

On Sun, Oct 27, 2019 at 02:21:22PM +0100, Sebastien Marie wrote:
> On Thu, Oct 24, 2019 at 06:18:19PM +0200, Stefan Sperling wrote:
> > There's a bug in stage -p where it fails if multiple files are involved.
> > 
> [...]
> >
> > Based on the above:
> > 
> > 1) If a file has no changes to stage in the -p case, move on to the
> > next file instead of reporting an error.
> > 
> > 2) If there is nothing to stage (with or without -p), print an error
> > and use an exit code != 0. The related test failed to take the exit
> > code into account, fix this.
> > 
> > ok?
> 
> the rational is good. the diff seems ok too.
> 
> ok semarie@

Committed. Thanks!



[prev in list] [next in list] [prev in thread] [next in thread]