[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fwts-devel
Subject:    ACK: [PATCH] acpi: acpitables: add advices for table revision tests
From:       ivanhu <ivan.hu () canonical ! com>
Date:       2021-06-28 5:44:18
Message-ID: 56f2e9d0-e9ea-8a3c-813c-d8d02670c5b9 () canonical ! com
[Download RAW message or body]



On 6/23/21 1:47 AM, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/acpi/acpitables/acpitables.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/src/acpi/acpitables/acpitables.c b/src/acpi/acpitables/acpitables.c
> index 67224633..2ecaaa33 100644
> --- a/src/acpi/acpitables/acpitables.c
> +++ b/src/acpi/acpitables/acpitables.c
> @@ -307,6 +307,12 @@ static int acpi_table_check_test2(fwts_framework *fw)
>  
>  	if (!failed)
>  		fwts_passed(fw, "ACPI spec %4.4" PRIx32 " has matched table revisions.", version);
> +	else
> +		fwts_advice(fw,
> +		"In \"ACPI Table Revision Overview\", ASWG suggests \"Conforming to a given ACPI "
> +		"specification means that each and every ACPI-related table conforms to the version "
> +		"number for that table that is listed in that version of the specification.\" "
> +		"Please refer to https://uefi.org/node/4185 for details.");
>  
>  	return FWTS_OK;
>  }
> 

Acked-by: Ivan Hu <ivan.hu@canonical.com>

-- 
fwts-devel mailing list
fwts-devel@lists.ubuntu.com
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/fwts-devel

[prev in list] [next in list] [prev in thread] [next in thread]