[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fwts-devel
Subject:    ACK: [PATCH 1/2] acpi: dbgp/spmi: check space ids by fwts_acpi_space_id
From:       ivanhu <ivan.hu () canonical ! com>
Date:       2021-05-19 2:43:56
Message-ID: e7be942c-f73b-e39b-42b9-f0a59041a21e () canonical ! com
[Download RAW message or body]



On 5/19/21 4:49 AM, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/acpi/dbgp/dbgp.c | 25 +++++++++++--------------
>  src/acpi/spmi/spmi.c | 15 +++++----------
>  2 files changed, 16 insertions(+), 24 deletions(-)
> 
> diff --git a/src/acpi/dbgp/dbgp.c b/src/acpi/dbgp/dbgp.c
> index 800b044b..dc45f4d5 100644
> --- a/src/acpi/dbgp/dbgp.c
> +++ b/src/acpi/dbgp/dbgp.c
> @@ -90,20 +90,17 @@ static int dbgp_test1(fwts_framework *fw)
>  			"DBGPBaseAddrBitWidthZero",
>  			"DBGP Base Address Bit Width is zero.");
>  	}
> -	switch (dbgp->base_address.address_space_id) {
> -	case 0x05 ... 0x09:
> -	case 0x0b ... 0x7e:
> -	case 0x80 ... 0xbf:
> -		passed = false;
> -		fwts_failed(fw, LOG_LEVEL_HIGH,
> -			"DBGPBaseAddrAddrSpaceID",
> -			"DBGP Base Address, Address Space ID 0x%" PRIx8
> -			" which is a reserved value.",
> -			dbgp->base_address.address_space_id);
> -		break;
> -	default:
> -		break;
> -	}
> +
> +	fwts_acpi_space_id(fw, "DBGP", "Base Address", &passed,
> +			   dbgp->base_address.address_space_id, 7,
> +			   FWTS_GAS_ADDR_SPACE_ID_SYSTEM_MEMORY,
> +			   FWTS_GAS_ADDR_SPACE_ID_SYSTEM_IO,
> +			   FWTS_GAS_ADDR_SPACE_ID_PCI_CONFIG,
> +			   FWTS_GAS_ADDR_SPACE_ID_EC,
> +			   FWTS_GAS_ADDR_SPACE_ID_SMBUS,
> +			   FWTS_GAS_ADDR_SPACE_ID_PCC,
> +			   FWTS_GAS_ADDR_SPACE_ID_FFH);
> +
>  done:
>  	if (passed)
>  		fwts_passed(fw, "No issues found in DBGP table.");
> diff --git a/src/acpi/spmi/spmi.c b/src/acpi/spmi/spmi.c
> index 3ab3d7fe..0dc7d08b 100644
> --- a/src/acpi/spmi/spmi.c
> +++ b/src/acpi/spmi/spmi.c
> @@ -138,16 +138,11 @@ static int spmi_test1(fwts_framework *fw)
>           * bits of the byte, and the most significant bit of the byte set to
>           */
>  	if (spmi->interface_type == 0x04) {
> -		if (spmi->base_address.address_space_id != FWTS_GAS_ADDR_SPACE_ID_SMBUS) {
> -			passed = false;
> -			fwts_failed(fw, LOG_LEVEL_MEDIUM,
> -				"SPMIInvalidAddressSpaceIDForSSIF",
> -				"SPMI Base Address Space ID is 0x%2.2" PRIx8
> -				" but should be 0x%2.2" PRIx8 " (SMBUS) "
> -				" for a SSIF Interface Type",
> -				spmi->base_address.address_space_id,
> -				FWTS_GAS_ADDR_SPACE_ID_SMBUS);
> -		}
> +
> +		fwts_acpi_space_id(fw, "SPMI", "Base Address for SSIF", &passed,
> +				   spmi->base_address.address_space_id, 1,
> +				   FWTS_GAS_ADDR_SPACE_ID_SMBUS);
> +
>  		if (spmi->base_address.address & ~0x7f) {
>  			passed = false;
>  			fwts_failed(fw, LOG_LEVEL_MEDIUM,
> 



Acked-by: Ivan Hu <ivan.hu@canonical.com>

-- 
fwts-devel mailing list
fwts-devel@lists.ubuntu.com
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/fwts-devel

[prev in list] [next in list] [prev in thread] [next in thread]