[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fwts-devel
Subject:    ACK: [PATCH 02/10] dmicheck: remove duplicated chassis type test in type 3
From:       ivanhu <ivan.hu () canonical ! com>
Date:       2020-05-28 6:29:20
Message-ID: 8816ad5a-4e41-b2d7-69c5-f2fb8d3919a8 () canonical ! com
[Download RAW message or body]



On 5/21/20 10:37 AM, Alex Hung wrote:
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
> src/dmi/dmicheck/dmicheck.c | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
> 
> diff --git a/src/dmi/dmicheck/dmicheck.c b/src/dmi/dmicheck/dmicheck.c
> index 46d7e620..f163c253 100644
> --- a/src/dmi/dmicheck/dmicheck.c
> +++ b/src/dmi/dmicheck/dmicheck.c
> @@ -1270,16 +1270,7 @@ static void dmicheck_entry(fwts_framework *fw,
> 			if (hdr->length < 0x09)
> 				break;
> 			dmi_str_check(fw, table, addr, "Manufacturer", hdr, 0x4);
> -			dmi_min_max_mask_uint8_check(fw, table, addr, "Chassis Type", hdr, 0x5, 0x1, \
>                 0x24, 0x0, 0x7f);
> -
> -			if ((data[5] & ~0x80) >= FWTS_SMBIOS_CHASSIS_MAX) {
> -				fwts_failed(fw, LOG_LEVEL_HIGH, DMI_INVALID_HARDWARE_ENTRY,
> -					"Incorrect Chassis Type "
> -					"SMBIOS Type 3 reports 0x%" PRIx8,
> -					(data[5] & ~0x80));
> -				break;
> -			}
> -
> +			dmi_min_max_mask_uint8_check(fw, table, addr, "Chassis Type", hdr, 0x5, 0x1, \
> FWTS_SMBIOS_CHASSIS_MAX - 1, 0x0, 0x7f);  dmi_min_max_mask_uint8_check(fw, table, \
> addr, "Chassis Lock", hdr, 0x5, 0x0, 0x1, 0x7, 0x1);  dmi_str_check(fw, table, \
> addr, "Version", hdr, 0x6);  dmi_str_check(fw, table, addr, "Serial Number", hdr, \
> 0x7); 

Acked-by: Ivan Hu <ivan.hu@canonical.com>

-- 
fwts-devel mailing list
fwts-devel@lists.ubuntu.com
Modify settings or unsubscribe at: \
https://lists.ubuntu.com/mailman/listinfo/fwts-devel


[prev in list] [next in list] [prev in thread] [next in thread]