[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fwts-devel
Subject:    ACK: [PATCH] lib: fwts_memorymap: fix resource leak on dir on error return path
From:       ivanhu <ivan.hu () canonical ! com>
Date:       2020-01-14 4:21:21
Message-ID: a51a4ee9-09ea-acb0-6690-aa745e4702a8 () canonical ! com
[Download RAW message or body]



On 1/13/20 7:48 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The error return path is leaking object dir, call closedir to fix
> this leak.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/lib/src/fwts_memorymap.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/lib/src/fwts_memorymap.c b/src/lib/src/fwts_memorymap.c
> index 241b552e..038ccd63 100644
> --- a/src/lib/src/fwts_memorymap.c
> +++ b/src/lib/src/fwts_memorymap.c
> @@ -315,6 +315,7 @@ fwts_list *fwts_memory_map_table_load(fwts_framework *fw)
>  			entry = fwts_memory_map_table_read_entry(directory->d_name);
>  			if (!entry) {
>  				fwts_memory_map_table_free(memory_map_list);
> +				(void)closedir(dir);
>  				return NULL;
>  			}
>  			fwts_list_add_ordered(memory_map_list, entry, fwts_fwts_memory_map_entry_compare);
> 


Acked-by: Ivan Hu <ivan.hu@canonical.com>

-- 
fwts-devel mailing list
fwts-devel@lists.ubuntu.com
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/fwts-devel

[prev in list] [next in list] [prev in thread] [next in thread]