[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fwts-devel
Subject:    ACK: [PATCH] lib: fwts_acpi_tables: remove redundant initialization to oem_tbl_id
From:       ivanhu <ivan.hu () canonical ! com>
Date:       2020-01-14 4:19:45
Message-ID: c991ce8f-08b8-c32d-1495-2b292c51b935 () canonical ! com
[Download RAW message or body]



On 1/13/20 7:31 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Pointer oem_tbl_id is being initialized with a value that is never read
> and it is being re-assigned later. The initialization is redundant and
> can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/lib/src/fwts_acpi_tables.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c
> index fe07edd5..3749c56a 100644
> --- a/src/lib/src/fwts_acpi_tables.c
> +++ b/src/lib/src/fwts_acpi_tables.c
> @@ -970,7 +970,7 @@ void fwts_acpi_fixup_addr_from_fadt(
>  static int fwts_acpi_load_tables_fixup(fwts_framework *fw)
>  {
>  	int i, j, count;
> -	char *oem_tbl_id = "FWTSIDXX";
> +	char *oem_tbl_id;
>  	fwts_acpi_table_info *table;
>  	fwts_acpi_table_rsdp *rsdp = NULL;
>  	fwts_acpi_table_fadt *fadt = NULL;
> 

Acked-by: Ivan Hu <ivan.hu@canonical.com>

-- 
fwts-devel mailing list
fwts-devel@lists.ubuntu.com
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/fwts-devel

[prev in list] [next in list] [prev in thread] [next in thread]