[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fwts-devel
Subject:    [PATCH] lib: fwts_acpi_tables: remove redundant initialization to oem_tbl_id
From:       Colin King <colin.king () canonical ! com>
Date:       2020-01-13 11:31:59
Message-ID: 20200113113159.165839-1-colin.king () canonical ! com
[Download RAW message or body]

From: Colin Ian King <colin.king@canonical.com>

Pointer oem_tbl_id is being initialized with a value that is never read
and it is being re-assigned later. The initialization is redundant and
can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/lib/src/fwts_acpi_tables.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c
index fe07edd5..3749c56a 100644
--- a/src/lib/src/fwts_acpi_tables.c
+++ b/src/lib/src/fwts_acpi_tables.c
@@ -970,7 +970,7 @@ void fwts_acpi_fixup_addr_from_fadt(
 static int fwts_acpi_load_tables_fixup(fwts_framework *fw)
 {
 	int i, j, count;
-	char *oem_tbl_id = "FWTSIDXX";
+	char *oem_tbl_id;
 	fwts_acpi_table_info *table;
 	fwts_acpi_table_rsdp *rsdp = NULL;
 	fwts_acpi_table_fadt *fadt = NULL;
-- 
2.24.0


-- 
fwts-devel mailing list
fwts-devel@lists.ubuntu.com
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/fwts-devel

[prev in list] [next in list] [prev in thread] [next in thread]