[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fwts-devel
Subject:    Re: [PATCH] efi_runtime: don't build dkms module for kernels 4.8.0 and above (LP: #1853090)
From:       You-Sheng Yang <vicamo.yang () canonical ! com>
Date:       2019-11-26 6:44:56
Message-ID: 99a931d3-ba18-f0bf-d0b6-4b07e2ec24ad () canonical ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


If so, then the other option is to fix the compile error when compiling
fwts dkms against v5.4 kernel with gcc-7.

Or, I know Debian has linux-compiler-gcc-<ver>-<arch> package that is a
Depends package for linux-headers-*, but Ubuntu doesn't have such thing.
So there doesn't seem to have a way to enforce compiler requirement in
the package management level or so. However, v5.4 mainline is still
supposed to compile with gcc-4.6 or above, and gcc-7 is surely included.
Is there really any reason that it's impossible to fix this compile
error instead?

You-Sheng Yang

On 2019-11-26 11:20, ivanhu wrote:
> I would like to keep this DKMS being built, if there are no high impacts.
> 
> Because the kernel 5.4 introduced the kernel lockdown,
> https://lkml.org/lkml/2019/9/10/856, which will lock down lots of IOs
> and inteerfaces accessing including uefi on efi_test.
> 
> Besides using the kernel parameters to disable kernel lockdown, this
> DKMS may be another choice which can be run by the fwts UEFI tests under
> kernel lockdown.
> 
> 
> Cheers,
> 
> Ivan
> 
> On 11/22/19 3:37 AM, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> BugLink: https://bugs.launchpad.net/bugs/1853090
>>
>> Use the dkms OBSOLETE_BY setting to skip building the efi driver
>> for kernels >= 4.8.0
>>
>> With this setting we get dkms installs to do the following:
>>
>> Unpacking fwts-efi-runtime-dkms (19.11.00-0ubuntu1) over (19.11.00-0ubuntu1) ...
>> Setting up fwts-efi-runtime-dkms (19.11.00-0ubuntu1) ...
>> Loading new fwts-efi-runtime-dkms-19.11.00 DKMS files...
>> Building for 5.3.0-19-generic
>> Building initial module for 5.3.0-19-generic
>> This system doesn't support Secure Boot
>> Secure Boot not enabled on this system.
>> Done.
>>
>> efi_runtime.ko:
>> Running module version sanity check.
>>
>> Module has been obsoleted due to being included
>> in kernel 4.8.0.  We will avoid installing
>> for future kernels above 4.8.0.
>> You may override by specifying --force.
>>
>> depmod...
>>
>> DKMS: install completed.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>>  debian/fwts-efi-runtime-dkms.dkms | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/debian/fwts-efi-runtime-dkms.dkms b/debian/fwts-efi-runtime-dkms.dkms
>> index 94b3415b..33c24e46 100644
>> --- a/debian/fwts-efi-runtime-dkms.dkms
>> +++ b/debian/fwts-efi-runtime-dkms.dkms
>> @@ -4,3 +4,4 @@ MAKE[0]="KVER=$kernelver make"
>>  BUILT_MODULE_NAME[0]="efi_runtime"
>>  DEST_MODULE_LOCATION[0]="/updates"
>>  AUTOINSTALL="yes"
>> +OBSOLETE_BY="4.8.0"
> 
> 


["signature.asc" (application/pgp-signature)]
[Attachment #8 (text/plain)]

-- 
fwts-devel mailing list
fwts-devel@lists.ubuntu.com
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/fwts-devel


[prev in list] [next in list] [prev in thread] [next in thread]