[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fwts-devel
Subject:    ACK: [PATCH][V2] acpi/boot: skip ACPI BOOT test on UEFI systems.
From:       ivanhu <ivan.hu () canonical ! com>
Date:       2019-09-20 12:58:24
Message-ID: b684621b-5c97-0ebf-bacd-776fe690e76c () canonical ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


On 9/19/19 6:09 PM, Alex Hung wrote:
> BOOT table is for PC-AT BIOS, and UEFI systems shall use
> SimpleBootFlag variable is stored in NVRAM.
>
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/acpi/boot/boot.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/src/acpi/boot/boot.c b/src/acpi/boot/boot.c
> index 081b8b37..c1ea810c 100644
> --- a/src/acpi/boot/boot.c
> +++ b/src/acpi/boot/boot.c
> @@ -35,6 +35,10 @@ static int boot_init(fwts_framework *fw)
>  		fwts_log_error(fw, "Cannot read ACPI tables.");
>  		return FWTS_ERROR;
>  	}
> +	if (fwts_firmware_detect() == FWTS_FIRMWARE_UEFI) {
> +		fwts_log_error(fw, "ACPI BOOT table is depreciated on UEFI firmware, skipping test");
> +		return FWTS_SKIP;
> +	}
>  	if (table == NULL || (table && table->length == 0)) {
>  		fwts_log_error(fw, "ACPI BOOT table does not exist, skipping test");
>  		return FWTS_SKIP;


Acked-by: Ivan Hu <ivan.hu@canonical.com>



["signature.asc" (application/pgp-signature)]
[Attachment #8 (text/plain)]

-- 
fwts-devel mailing list
fwts-devel@lists.ubuntu.com
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/fwts-devel


[prev in list] [next in list] [prev in thread] [next in thread]