'ACK: [PATCH] snapcraft: remove libjson-c3 stage package, it is not required'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fwts-devel
Subject:    ACK: [PATCH] snapcraft: remove libjson-c3 stage package, it is not required
From:       ivanhu <ivan.hu () canonical ! com>
Date:       2018-08-22 2:31:41
Message-ID: d2fc253a-9283-83bc-108e-92ceddcd9f77 () canonical ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]

[Attachment #6 (multipart/alternative)]


On 08/22/2018 03:22 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Removing libjson-c3 stage package fixes a snap build failure on
> Xenial, it is not required, so remove it.
>
> Fixes snap build error:
> Fetched 4780 kB in 0s (0 B/s)
> Failed to fetch stage packages: Error downloading packages for
> part 'fwts': The package 'libjson-c3' was not found..
>
> Fixes: a6d5fc26e93d ("snapcraft: add missing stage packages")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  snapcraft.yaml | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/snapcraft.yaml b/snapcraft.yaml
> index 30d42b1b..37a82c4b 100644
> --- a/snapcraft.yaml
> +++ b/snapcraft.yaml
> @@ -10,7 +10,6 @@ parts:
>          source: git://kernel.ubuntu.com/hwe/fwts
>          stage-packages:
>              - libfdt1
> -            - libjson-c3
>              - libbsd0
>              - libpci3
>          build-packages:

Acked-by: Ivan Hu <ivan.hu@canonical.com>

[Attachment #9 (text/html)]

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <p><br>
    </p>
    <br>
    <div class="moz-cite-prefix">On 08/22/2018 03:22 AM, Colin King
      wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:20180821192227.12849-1-colin.king@canonical.com">
      <pre wrap="">From: Colin Ian King <a class="moz-txt-link-rfc2396E" \
href="mailto:colin.king@canonical.com">&lt;colin.king@canonical.com&gt;</a>

Removing libjson-c3 stage package fixes a snap build failure on
Xenial, it is not required, so remove it.

Fixes snap build error:
Fetched 4780 kB in 0s (0 B/s)
Failed to fetch stage packages: Error downloading packages for
part 'fwts': The package 'libjson-c3' was not found..

Fixes: a6d5fc26e93d ("snapcraft: add missing stage packages")
Signed-off-by: Colin Ian King <a class="moz-txt-link-rfc2396E" \
                href="mailto:colin.king@canonical.com">&lt;colin.king@canonical.com&gt;</a>
                
---
 snapcraft.yaml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/snapcraft.yaml b/snapcraft.yaml
index 30d42b1b..37a82c4b 100644
--- a/snapcraft.yaml
+++ b/snapcraft.yaml
@@ -10,7 +10,6 @@ parts:
         source: git://kernel.ubuntu.com/hwe/fwts
         stage-packages:
             - libfdt1
-            - libjson-c3
             - libbsd0
             - libpci3
         build-packages:
</pre>
    </blockquote>
    <br>
    Acked-by: Ivan Hu <a class="moz-txt-link-rfc2396E"
      href="mailto:ivan.hu@canonical.com">&lt;ivan.hu@canonical.com&gt;</a>
  </body>
</html>


["signature.asc" (application/pgp-signature)]
[Attachment #11 (text/plain)]

-- 
fwts-devel mailing list
fwts-devel@lists.ubuntu.com
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/fwts-devel


[prev in list] [next in list] [prev in thread] [next in thread] 
