'ACK: [PATCH] snapcraft: add missing stage packages'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fwts-devel
Subject:    ACK: [PATCH] snapcraft: add missing stage packages
From:       ivanhu <ivan.hu () canonical ! com>
Date:       2018-08-21 7:33:24
Message-ID: 5b774261-b24b-ab7d-1012-5cba0a6830dc () canonical ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]

[Attachment #6 (multipart/alternative)]


On 08/20/2018 11:38 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> This includes some missing stage packages
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  snapcraft.yaml | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/snapcraft.yaml b/snapcraft.yaml
> index 7b36b314..30d42b1b 100644
> --- a/snapcraft.yaml
> +++ b/snapcraft.yaml
> @@ -10,6 +10,9 @@ parts:
>          source: git://kernel.ubuntu.com/hwe/fwts
>          stage-packages:
>              - libfdt1
> +            - libjson-c3
> +            - libbsd0
> +            - libpci3
>          build-packages:
>              - gcc
>              - make

Acked-by: Ivan Hu <ivan.hu@canonical.com>

[Attachment #9 (text/html)]

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <p><br>
    </p>
    <br>
    <div class="moz-cite-prefix">On 08/20/2018 11:38 PM, Colin King
      wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:20180820153811.13353-1-colin.king@canonical.com">
      <pre wrap="">From: Colin Ian King <a class="moz-txt-link-rfc2396E" \
href="mailto:colin.king@canonical.com">&lt;colin.king@canonical.com&gt;</a>

This includes some missing stage packages

Signed-off-by: Colin Ian King <a class="moz-txt-link-rfc2396E" \
                href="mailto:colin.king@canonical.com">&lt;colin.king@canonical.com&gt;</a>
                
---
 snapcraft.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/snapcraft.yaml b/snapcraft.yaml
index 7b36b314..30d42b1b 100644
--- a/snapcraft.yaml
+++ b/snapcraft.yaml
@@ -10,6 +10,9 @@ parts:
         source: git://kernel.ubuntu.com/hwe/fwts
         stage-packages:
             - libfdt1
+            - libjson-c3
+            - libbsd0
+            - libpci3
         build-packages:
             - gcc
             - make
</pre>
    </blockquote>
    <br>
    Acked-by: Ivan Hu <a class="moz-txt-link-rfc2396E"
      href="mailto:ivan.hu@canonical.com">&lt;ivan.hu@canonical.com&gt;</a>
  </body>
</html>


["signature.asc" (application/pgp-signature)]
[Attachment #11 (text/plain)]

-- 
fwts-devel mailing list
fwts-devel@lists.ubuntu.com
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/fwts-devel


[prev in list] [next in list] [prev in thread] [next in thread] 
