'ACK: [PATCH 22/27] opal: reserv_mem: add in missing const to fix build warnings'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fwts-devel
Subject:    ACK: [PATCH 22/27] opal: reserv_mem: add in missing const to fix build warnings
From:       ivanhu <ivan.hu () canonical ! com>
Date:       2018-08-16 9:19:35
Message-ID: e57553cd-d3af-f79f-8036-da8fc901cee1 () canonical ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]

[Attachment #6 (multipart/alternative)]


On 08/15/2018 09:11 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add in missing const, cleans up warnings.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/opal/reserv_mem.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/opal/reserv_mem.c b/src/opal/reserv_mem.c
> index 4683f73c..b42b959b 100644
> --- a/src/opal/reserv_mem.c
> +++ b/src/opal/reserv_mem.c
> @@ -125,7 +125,7 @@ static int reserv_mem_init(fwts_framework *fw)
>  static int reserv_mem_limits_test(fwts_framework *fw)
>  {
>  	bool ok = true;
> -	char *region_names;
> +	const char *region_names;
>  	const uint64_t *ranges;
>  	reserve_region_t *regions;
>  	int  offset, len, nr_regions, rc, j;
> @@ -145,7 +145,7 @@ static int reserv_mem_limits_test(fwts_framework *fw)
>  				"reserved-names");
>  
>  	/* Check for the reservd-names property */
> -	region_names = (char *)fdt_getprop(fw->fdt, offset,
> +	region_names = (const char *)fdt_getprop(fw->fdt, offset,
>  					"reserved-names", &len);
>  	if (!region_names) {
>  		fwts_failed(fw, LOG_LEVEL_MEDIUM, "DTPropertyMissing",

Acked-by: Ivan Hu <ivan.hu@canonical.com>

[Attachment #9 (text/html)]

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <p><br>
    </p>
    <br>
    <div class="moz-cite-prefix">On 08/15/2018 09:11 PM, Colin King
      wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:20180815131129.24146-23-colin.king@canonical.com">
      <pre wrap="">From: Colin Ian King <a class="moz-txt-link-rfc2396E" \
href="mailto:colin.king@canonical.com">&lt;colin.king@canonical.com&gt;</a>

Add in missing const, cleans up warnings.

Signed-off-by: Colin Ian King <a class="moz-txt-link-rfc2396E" \
                href="mailto:colin.king@canonical.com">&lt;colin.king@canonical.com&gt;</a>
                
---
 src/opal/reserv_mem.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/opal/reserv_mem.c b/src/opal/reserv_mem.c
index 4683f73c..b42b959b 100644
--- a/src/opal/reserv_mem.c
+++ b/src/opal/reserv_mem.c
@@ -125,7 +125,7 @@ static int reserv_mem_init(fwts_framework *fw)
 static int reserv_mem_limits_test(fwts_framework *fw)
 {
 	bool ok = true;
-	char *region_names;
+	const char *region_names;
 	const uint64_t *ranges;
 	reserve_region_t *regions;
 	int  offset, len, nr_regions, rc, j;
@@ -145,7 +145,7 @@ static int reserv_mem_limits_test(fwts_framework *fw)
 				"reserved-names");
 
 	/* Check for the reservd-names property */
-	region_names = (char *)fdt_getprop(fw-&gt;fdt, offset,
+	region_names = (const char *)fdt_getprop(fw-&gt;fdt, offset,
 					"reserved-names", &amp;len);
 	if (!region_names) {
 		fwts_failed(fw, LOG_LEVEL_MEDIUM, "DTPropertyMissing",
</pre>
    </blockquote>
    <br>
    Acked-by: Ivan Hu <a class="moz-txt-link-rfc2396E"
      href="mailto:ivan.hu@canonical.com">&lt;ivan.hu@canonical.com&gt;</a>
  </body>
</html>


["signature.asc" (application/pgp-signature)]
[Attachment #11 (text/plain)]

-- 
fwts-devel mailing list
fwts-devel@lists.ubuntu.com
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/fwts-devel


[prev in list] [next in list] [prev in thread] [next in thread] 
