[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fwts-devel
Subject:    ACK: [PATCH 1/2] fwts-frontend-text: add a recommended option for IFV (IBV)
From:       ivanhu <ivan.hu () canonical ! com>
Date:       2018-05-09 6:56:26
Message-ID: a861b26e-1252-8dc7-dd27-06e1a66b0c10 () canonical ! com
[Download RAW message or body]



On 05/04/2018 04:50 PM, Alex Hung wrote:
> The option uses a new option --ifv that skips don't-care failures
> such as "To be filled by OEM" in dmicheck.
> 
> This patch also removes some trailing spaces.
> 
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
> live-image/fwts-frontend-text | 16 +++++++++++-----
> 1 file changed, 11 insertions(+), 5 deletions(-)
> 
> diff --git a/live-image/fwts-frontend-text b/live-image/fwts-frontend-text
> index 5ef255a..7156f28 100755
> --- a/live-image/fwts-frontend-text
> +++ b/live-image/fwts-frontend-text
> @@ -45,7 +45,7 @@ FWTS_AUTO_SHUTDOWN="$1"
> SHUTDOWN_AT_END=0
> 
> #
> -# set WORK_DIR to /cdrom/fwts if booting via casper
> +# set WORK_DIR to /cdrom/fwts if booting via casper
> #
> if [ `grep -qs boot=casper /proc/cmdline; echo $?` -eq 0 ]; then
> 	CASPER_DETECTED=1
> @@ -76,7 +76,7 @@ do_help()
> #
> do_test()
> {
> -	
> +
> 	num_tests=`fwts $1 --show-tests | wc -l`
> 	num_tests=$((num_tests - 1))
> 	if [ $num_tests -gt 0 ]; then
> @@ -106,7 +106,7 @@ select_tests()
> 			txt="${txt} ${x} \"${text}\" off"
> 		done < $OPTIONS
> 		rm $OPTIONS
> -	
> +
> 		#
> 		# Construct and run dialog
> 		#
> @@ -157,7 +157,7 @@ select_tests()
> #  View the results log
> #
> view_results()
> -{	
> +{
> 	tempfile=/tmp/view_results.tmp.$$
> 	dialog --print-maxsize 2>| $tempfile
> 	term_height=`sed -n "s/^MaxSize: \([0-9]*\), \([0-9]*\)$/\1/p" $tempfile 2> \
> /dev/null` @@ -278,11 +278,12 @@ do
> 		*)
> 			dialog --help-button --backtitle "$FWTS" --title "Select Tests" --radiolist \
> 			"This will run a suite of firmware tests that will check the BIOS and ACPI \
> tables.  It can also find issues that can cause Linux problems.\n\nThe default \
> below is to run just all the Batch Tests, but you can select more tests below if \
> required.\n\nPlease select below (using cursor up/down and space) and press enter \
>                 to continue."\
> -			22 70 6 \
> +			24 70 7 \
> 			"All" "All Batch Tests" on \
> 			"ACPI" "ACPI Tests" off \
> 			"UEFI" "UEFI Tests" off \
> 			"Recommended" "Recommended Tests" off \
> +			"Recommended for IFV" "Recommended Tests for F/W Vendors" off \
> 			"Selected" "Select Individual Tests" off \
> 			"Abort" "Abort Testing" off \
> 			2> $OPTIONS
> @@ -327,6 +328,11 @@ do
> 			do_test "${FWTS_OPTIONS}" 'Running Recommended Tests'
> 			done_tests_finish
> 			;;
> +		'Recommended for IFV')
> +			FWTS_OPTIONS="version cpufreq maxfreq msr mtrr nx virt aspm dmicheck apicedge \
> klog oops --acpitests --uefitests --ifv --skip-test=s3,s4" +			do_test \
> "${FWTS_OPTIONS}" 'Running Recommended Tests for F/W Vendors' +			done_tests_finish
> +			;;
> 		'Selected')
> 			select_tests
> 			;;
> 

Acked-by: Ivan Hu <ivan.hu@canonical.com>

-- 
fwts-devel mailing list
fwts-devel@lists.ubuntu.com
Modify settings or unsubscribe at: \
https://lists.ubuntu.com/mailman/listinfo/fwts-devel


[prev in list] [next in list] [prev in thread] [next in thread]