[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fwts-devel
Subject:    ACK: [PATCH] opal: cpu_info: Designate property optional
From:       ivanhu <ivan.hu () canonical ! com>
Date:       2018-05-09 6:54:21
Message-ID: 66626fc1-3399-bf52-4f14-749bc6c15139 () canonical ! com
[Download RAW message or body]



On 04/07/2018 06:10 AM, Deb McLemore wrote:
> Some properties do not apply per platform.
> 
> Signed-off-by: Deb McLemore <debmc@linux.vnet.ibm.com>
> ---
>   src/opal/cpu_info.c | 16 ++++------------
>   1 file changed, 4 insertions(+), 12 deletions(-)
> 
> diff --git a/src/opal/cpu_info.c b/src/opal/cpu_info.c
> index f923653..9dc084b 100644
> --- a/src/opal/cpu_info.c
> +++ b/src/opal/cpu_info.c
> @@ -88,19 +88,11 @@ static int get_xscom_property(fwts_framework *fw,
>   						my_path);
>   				}
>   			} else {
> -				failures ++;
>   				fwts_log_nl(fw);
> -				fwts_failed(fw,
> -					LOG_LEVEL_CRITICAL,
> -					"OPAL CPU Info",
> -					"Property of \"%s\" for \"%s\" was"
> -					" not able to be retrieved. Check the"
> -					" installation for the CPU device"
> -					" config for missing nodes in the"
> -					" device tree if you expect CPU"
> -					" devices.",
> -					property,
> -					my_path);
> +				fwts_skipped(fw, "OPAL CPU check for "
> +					"property of \"%s\" and path of \"%s\""
> +					" not applicable to version.",
> +					property, my_path);
>   			}
>   		} else {
>   			failures ++;
> 

Acked-by: Ivan Hu <ivan.hu@canonical.com>

-- 
fwts-devel mailing list
fwts-devel@lists.ubuntu.com
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/fwts-devel

[prev in list] [next in list] [prev in thread] [next in thread]