[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fwts-devel
Subject:    ACK: [PATCH 2/3] acpi: hest: add notification type 11 according to ACPI 6.2 (mantis 1731)
From:       Colin Ian King <colin.king () canonical ! com>
Date:       2017-06-23 8:06:23
Message-ID: a4bedf90-dc71-2ea0-c792-ba862e203869 () canonical ! com
[Download RAW message or body]

On 22/06/17 03:32, Alex Hung wrote:
> This patch also changes notification type to decimal numbers as in ACPI
> Spec.
> 
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  src/acpi/hest/hest.c | 22 ++++++++++++++++------
>  1 file changed, 16 insertions(+), 6 deletions(-)
> 
> diff --git a/src/acpi/hest/hest.c b/src/acpi/hest/hest.c
> index fb2e5fe..08b60ce 100644
> --- a/src/acpi/hest/hest.c
> +++ b/src/acpi/hest/hest.c
> @@ -208,6 +208,16 @@ static void hest_check_ia32_arch_corrected_machine_check(
>  	fwts_log_info_verbatim(fw, "  Reserved:                 0x%2.2" PRIx8, check->reserved2[2]);
>  	fwts_log_nl(fw);
>  
> +	if (check->notification.type > 11) {
> +		*passed = false;
> +		fwts_failed(fw, LOG_LEVEL_HIGH,
> +			"HESTInvalidHardwareErrorNotificationType",
> +			"HEST Hardware Error Notification Type is "
> +			"an invalid reserved value of %2.2" PRIu8 ","
> +			"expecting value 0 to 11",
> +			check->notification.type);
> +	}
> +
>  	for (i = 0; i < check->number_of_hardware_banks; i++) {
>  		fwts_acpi_table_hest_machine_check_bank *bank = &check->bank[i];
>  
> @@ -645,13 +655,13 @@ static void hest_check_generic_error_source(
>  			"more than zero.",
>  			source->max_sections_per_record);
>  	}
> -	if (source->notification.type > 0xA) {
> +	if (source->notification.type > 11) {
>  		*passed = false;
>  		fwts_failed(fw, LOG_LEVEL_HIGH,
>  			"HESTInvalidHardwareErrorNotificationType",
>  			"HEST Hardware Error Notification Type is "
> -			"an invalid reserved value of 0x%2.2" PRIx8 ","
> -			"expecting value 0x00 to 0x0A",
> +			"an invalid reserved value of %2.2" PRIu8 ","
> +			"expecting value 0 to 11",
>  			source->notification.type);
>  	}
>  	if (source->notification.configuration_write_enable & ~0x3f) {
> @@ -763,13 +773,13 @@ static void hest_check_generic_error_source_v2(
>  			"more than zero.",
>  			source->max_sections_per_record);
>  	}
> -	if (source->notification.type > 0xA) {
> +	if (source->notification.type > 11) {
>  		*passed = false;
>  		fwts_failed(fw, LOG_LEVEL_HIGH,
>  			"HESTInvalidHardwareErrorNotificationType",
>  			"HEST Hardware Error Notification Type is "
> -			"an invalid reserved value of 0x%2.2" PRIx8 ","
> -			"expecting value 0x00 to 0x0A",
> +			"an invalid reserved value of %2.2" PRIu8 ","
> +			"expecting value 0 to 11",
>  			source->notification.type);
>  	}
>  	if (source->notification.configuration_write_enable & ~0x3f) {
> 
Acked-by: Colin Ian King <colin.king@canonical.com>

-- 
fwts-devel mailing list
fwts-devel@lists.ubuntu.com
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/fwts-devel
[prev in list] [next in list] [prev in thread] [next in thread]