[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fwts-devel
Subject:    [PATCH 0/3] Add more sanity checking with broken ACPI dump input
From:       Colin King <colin.king () canonical ! com>
Date:       2017-03-24 16:10:12
Message-ID: 20170324161015.8664-1-colin.king () canonical ! com
[Download RAW message or body]

From: Colin Ian King <colin.king@canonical.com>

While running fwts against a varied input of ACPI dump files I hit an
issue were broken data was causing ACPICA to segfault. I tracked this
down to the way non-existent tables such as the DSDT were being passed
to ACPICA.  For example, with the DSDT being corrupted and not parsable
by the fwts data loader we still may have the FACP pointing to the DSDT
even though it does not exist.

These patches fix two issues.  One is adding extra sanity checking to
the ACPICA front-end before we try to execute AML - the check ensures
that tables the the FACP points to (DSTD, FACS) exist and if not we
abort early.

The second patch handles the cases where the ACPI dump loader loads
in the FACS or DSDT and there is no address information provided in
the dump data being loaded, so we need to fix up there addresses
from the addresses provided by the FACP (FADT).

The final patch caters for changes in the fixed-up data when loading
ACPI tables from a faked-up ACPICA dump that has been used in the
tests.

Colin Ian King (3):
  acpica: add some extra run time verification to FACP (FADT)
  lib: fwts_acpi_tables: Add extra fix-up for FACS and DSDT table
    addresses
  fwts-test: arg-table-path-0001: sync tests with latest fwts changes

 fwts-test/arg-table-path-0001/acpidump-0001.log |  16 +-
 fwts-test/arg-table-path-0001/acpidump-0002.log | 410 ++++++++++++++++++++++++
 src/acpica/fwts_acpica.c                        |  70 ++++
 src/lib/src/fwts_acpi_tables.c                  |  56 +++-
 4 files changed, 538 insertions(+), 14 deletions(-)
 create mode 100644 fwts-test/arg-table-path-0001/acpidump-0002.log

-- 
2.11.0


-- 
fwts-devel mailing list
fwts-devel@lists.ubuntu.com
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/fwts-devel
[prev in list] [next in list] [prev in thread] [next in thread]