[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fwts-devel
Subject:    Re: [PATCH 07/12] sbbr/madt: Add initial tests to madt acpi table as per sbbr.
From:       Leif Lindholm <leif.lindholm () linaro ! org>
Date:       2017-03-07 8:11:22
Message-ID: 20170307081122.GE16034 () bivouac ! eciton ! net
[Download RAW message or body]

On Mon, Mar 06, 2017 at 11:59:36AM -0600, Supreeth Venkatesh wrote:
> On Thu, 2017-03-02 at 23:39 +0000, Colin Ian King wrote:
> > This seems to be derived from the other fwts MADT test, so we've got
> > code duplication here. Any specific reasons?
> > 
> Yes. there is some code re-use. But this removes x86 specific Interrupt
> controller tests and retains only GIC tests with additional tests
> added.

This separation should be done conditionally, based on whether the
--sbbr option has been specified, or at compile time per architecture
for any tables that are architecture specific.

Not by duplicating code (and hence the maintenance burden).

/
    Leif

-- 
fwts-devel mailing list
fwts-devel@lists.ubuntu.com
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/fwts-devel
[prev in list] [next in list] [prev in thread] [next in thread]