'ACK: [PATCH] klog.json: fix a couple of klog patterns'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fwts-devel
Subject:    ACK: [PATCH] klog.json: fix a couple of klog patterns
From:       ivanhu <ivan.hu () canonical ! com>
Date:       2017-02-14 8:05:43
Message-ID: 66b82860-4d56-66ce-5738-5586e66ec8a8 () canonical ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On 2017年02月10日 19:41, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> One of the patterns should have been a regex, and another pattern is too
> restrictive, so make it a bit more slack to pick up changes with the
> pattern in newer kernels.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> data/klog.json | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/data/klog.json b/data/klog.json
> index 55ff2f3..d4980c3 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -317,7 +317,7 @@
> "label": "KlogBios32UnsupportedRevision",
> },
> {
> -   "compare_mode": "string",
> +   "compare_mode": "regex",
> "log_level": "LOG_LEVEL_MEDIUM",
> "pattern": "PCI: BIOS32 entry .* in high memory, cannot use",
> "advice": "The BIOS32 service directory structure in located in high memory at or \
> above address 0x100000 and cannot use this.", @@ -746,7 +746,7 @@
> {
> "compare_mode": "string",
> "log_level": "LOG_LEVEL_LOW",
> -   "pattern": "Misaligned resource pointer (get):",
> +   "pattern": "Misaligned resource pointer",
> "advice": "The ACPI driver detected a resource pointer that is not naturally \
> aligned to a 32 bit boundary. This has been automatically fixed and should not \
> cause any issues.", "label": "KlogAcpiResourceDescriptorError"
> },

Acked-by: Ivan Hu <ivan.hu@canonical.com>


[Attachment #5 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <p><br>
    </p>
    <br>
    <div class="moz-cite-prefix">On 2017年02月10日 19:41, Colin King wrote:<br>
    </div>
    <blockquote
      cite="mid:20170210114104.28700-1-colin.king@canonical.com"
      type="cite">
      <pre wrap="">From: Colin Ian King <a class="moz-txt-link-rfc2396E" \
href="mailto:colin.king@canonical.com">&lt;colin.king@canonical.com&gt;</a>

One of the patterns should have been a regex, and another pattern is too
restrictive, so make it a bit more slack to pick up changes with the
pattern in newer kernels.

Signed-off-by: Colin Ian King <a class="moz-txt-link-rfc2396E" \
                href="mailto:colin.king@canonical.com">&lt;colin.king@canonical.com&gt;</a>
                
---
 data/klog.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/data/klog.json b/data/klog.json
index 55ff2f3..d4980c3 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -317,7 +317,7 @@
    "label": "KlogBios32UnsupportedRevision",
   },
   {
-   "compare_mode": "string",
+   "compare_mode": "regex",
    "log_level": "LOG_LEVEL_MEDIUM",
    "pattern": "PCI: BIOS32 entry .* in high memory, cannot use",
    "advice": "The BIOS32 service directory structure in located in high memory at or \
above address 0x100000 and cannot use this.", @@ -746,7 +746,7 @@
   {
    "compare_mode": "string",
    "log_level": "LOG_LEVEL_LOW",
-   "pattern": "Misaligned resource pointer (get):",
+   "pattern": "Misaligned resource pointer",
    "advice": "The ACPI driver detected a resource pointer that is not naturally \
aligned to a 32 bit boundary. This has been automatically fixed and should not cause \
any issues.",  "label": "KlogAcpiResourceDescriptorError"
   },
</pre>
    </blockquote>
    <br>
    Acked-by: Ivan Hu <a class="moz-txt-link-rfc2396E"
      href="mailto:ivan.hu@canonical.com">&lt;ivan.hu@canonical.com&gt;</a>
  </body>
</html>



-- 
fwts-devel mailing list
fwts-devel@lists.ubuntu.com
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/fwts-devel


[prev in list] [next in list] [prev in thread] [next in thread] 
