[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fwts-devel
Subject:    ACK: [PATCH] acpi: hest: Add new error notification types
From:       Alex Hung <alex.hung () canonical ! com>
Date:       2016-09-26 21:20:23
Message-ID: ff6120b2-6c3f-374a-5dbe-d6fe20361827 () canonical ! com
[Download RAW message or body]

On 2016-09-21 03:27 PM, Jeffrey Hugo wrote:
> ACPI 6.1 updated Table 18-345 in Section 18.3.2.9 with additional error
> notification types.  Types 0 - 10 are now defined.  Update the test
> accordingly to prevent false reserved type errors.
>
> Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
> ---
>  src/acpi/hest/hest.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/acpi/hest/hest.c b/src/acpi/hest/hest.c
> index 1d1fa71..eded048 100644
> --- a/src/acpi/hest/hest.c
> +++ b/src/acpi/hest/hest.c
> @@ -645,13 +645,13 @@ static void hest_check_generic_error_source(
>  			"more than zero.",
>  			source->max_sections_per_record);
>  	}
> -	if (source->notification.type > 7) {
> +	if (source->notification.type > 0xA) {
>  		*passed = false;
>  		fwts_failed(fw, LOG_LEVEL_HIGH,
>  			"HESTInvalidHardwareErrorNotificationType",
>  			"HEST Hardware Error Notification Type is "
>  			"an invalid reserved value of 0x%2.2" PRIx8 ","
> -			"expecting value 0x00 to 0x07",
> +			"expecting value 0x00 to 0x0A",
>  			source->notification.type);
>  	}
>  	if (source->notification.configuration_write_enable & ~0x3f) {
> @@ -763,13 +763,13 @@ static void hest_check_generic_error_source_v2(
>  			"more than zero.",
>  			source->max_sections_per_record);
>  	}
> -	if (source->notification.type > 7) {
> +	if (source->notification.type > 0xA) {
>  		*passed = false;
>  		fwts_failed(fw, LOG_LEVEL_HIGH,
>  			"HESTInvalidHardwareErrorNotificationType",
>  			"HEST Hardware Error Notification Type is "
>  			"an invalid reserved value of 0x%2.2" PRIx8 ","
> -			"expecting value 0x00 to 0x07",
> +			"expecting value 0x00 to 0x0A",
>  			source->notification.type);
>  	}
>  	if (source->notification.configuration_write_enable & ~0x3f) {
>


Acked-by: Alex Hung <alex.hung@canonical.com>

-- 
fwts-devel mailing list
fwts-devel@lists.ubuntu.com
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/fwts-devel
[prev in list] [next in list] [prev in thread] [next in thread]