[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fwts-devel
Subject:    Re: [PATCH] update_version.sh: Insert just date + time in date stamp
From:       Keng-Yu Lin <kengyu () canonical ! com>
Date:       2013-02-26 9:00:01
Message-ID: CADXHx7a-+Eeq-fm06hWC79ZqdWYumSOawdsF2mpiX-4X2OEOpw () mail ! gmail ! com
[Download RAW message or body]

On Sat, Feb 23, 2013 at 1:08 AM, Colin King <colin.king@canonical.com> wrot=
e:
> From: Colin Ian King <colin.king@canonical.com>
>
> The update_version.sh script is inserting some international strings
> into the FWTS_DATE string which is not was intended.  For example:
>
> fwts -v
> fwts, Version V0.26.05, =E5=9B=9B 2=E6=9C=88 7 09:14:47 CST 2013
>
> ..so alter this so we just dump the date and time as digits and
> don't dump out the day or month strings.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  update_version.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/update_version.sh b/update_version.sh
> index dae8141..2eefe10 100755
> --- a/update_version.sh
> +++ b/update_version.sh
> @@ -27,7 +27,7 @@ cat << EOF > src/lib/include/fwts_version.h
>   */
>  EOF
>  echo '#define FWTS_VERSION "'$version'"' >> src/lib/include/fwts_version=
.h
> -echo '#define FWTS_DATE    "'`date`'"' >> src/lib/include/fwts_version.h
> +echo '#define FWTS_DATE    "'`date "+%x %T"`'"' >> src/lib/include/fwts_=
version.h
>  git add src/lib/include/fwts_version.h
>  git commit -s -m"lib: fwts_version.h - update to $version"
>  git tag -m'"Version '$1'"' $1
> --
> 1.8.1.2
>

Thanks for fixing this. :-)

Acked-by: Keng-Yu Lin <kengyu@canonical.com>


[prev in list] [next in list] [prev in thread] [next in thread]