[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fwts-devel
Subject:    ACK: [PATCH] wmi.c: fix build error when using gcc 4.6.3
From:       Alex Hung <alex.hung () canonical ! com>
Date:       2013-02-21 6:52:09
Message-ID: 5125C419.3050607 () canonical ! com
[Download RAW message or body]

On 02/21/2013 02:41 PM, Ivan Hu wrote:
> With the precise of gcc 4.6.3 version we get the build error:
>
> acpi/wmi/wmi.c:256:2: error: expected ‘)' before ‘PRIx8'
> acpi/wmi/wmi.c:256:2: error: conversion lacks type at end of format [-Werror=format]
> acpi/wmi/wmi.c:260:2: error: expected ‘)' before ‘PRIx8'
> acpi/wmi/wmi.c:260:2: error: conversion lacks type at end of format [-Werror=format]
> acpi/wmi/wmi.c: In function ‘wmi_parse_wdg_data':
> acpi/wmi/wmi.c:314:4: error: expected ‘)' before ‘PRIx8'
> acpi/wmi/wmi.c:314:4: error: conversion lacks type at end of format [-Werror=format]
> acpi/wmi/wmi.c:316:4: error: expected ‘)' before ‘PRIx8'
> acpi/wmi/wmi.c:316:4: error: conversion lacks type at end of format [-Werror=format]
> acpi/wmi/wmi.c:318:4: error: expected ‘)' before ‘PRIx8'
> acpi/wmi/wmi.c:318:4: error: conversion lacks type at end of format [-Werror=format]
> acpi/wmi/wmi.c:320:4: error: expected ‘)' before ‘PRIx8'
> acpi/wmi/wmi.c:320:4: error: conversion lacks type at end of format [-Werror=format]
>
> because some required headers were left out.
>
> Signed-off-by: Ivan Hu <ivan.hu@canonical.com>
> ---
>   src/acpi/wmi/wmi.c |    2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/src/acpi/wmi/wmi.c b/src/acpi/wmi/wmi.c
> index 6401b41..2425be1 100644
> --- a/src/acpi/wmi/wmi.c
> +++ b/src/acpi/wmi/wmi.c
> @@ -27,6 +27,8 @@
>   #include <unistd.h>
>   #include <string.h>
>   #include <ctype.h>
> +#include <stdint.h>
> +#include <inttypes.h>
>
>   /* acpica headers */
>   #include "acpi.h"
>
Acked-by: Alex Hung <alex.hung@canonical.com>


[prev in list] [next in list] [prev in thread] [next in thread]