[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fwts-devel
Subject:    Re: [PATCH 1/3] kernel: version: strip off trailing newline
From:       Keng-Yu Lin <kengyu () canonical ! com>
Date:       2012-05-31 6:56:45
Message-ID: CADXHx7ZVyt8bBE0EfmUMP6vo+Scort0qT83=fKGpp4FGhdhMAg () mail ! gmail ! com
[Download RAW message or body]

On Tue, May 29, 2012 at 9:11 PM, Colin King <colin.king@canonical.com> wrot=
e:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> =C2=A0src/kernel/version/version.c | =C2=A0 =C2=A03 +++
> =C2=A01 file changed, 3 insertions(+)
>
> diff --git a/src/kernel/version/version.c b/src/kernel/version/version.c
> index c56882b..37ed5b5 100644
> --- a/src/kernel/version/version.c
> +++ b/src/kernel/version/version.c
> @@ -28,6 +28,7 @@ static int version_test1(fwts_framework *fw)
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0fwts_warning(fw,
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0"Cannot get version signature info from /proc/version_signature (=
This is Ubuntu specific, and not necessarily a failure).");
> =C2=A0 =C2=A0 =C2=A0 =C2=A0else {
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 fwts_chop_newline(str)=
;
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0fwts_passed(fw, "S=
ignature: %s", str);
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0free(str);
> =C2=A0 =C2=A0 =C2=A0 =C2=A0}
> @@ -44,6 +45,7 @@ static int version_test2(fwts_framework *fw)
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0"KernelProcVersion",
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0"Cannot get version info from /proc/version");
> =C2=A0 =C2=A0 =C2=A0 =C2=A0else {
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 fwts_chop_newline(str)=
;
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0fwts_passed(fw, "K=
ernel Version: %s", str);
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0free(str);
> =C2=A0 =C2=A0 =C2=A0 =C2=A0}
> @@ -60,6 +62,7 @@ static int version_test3(fwts_framework *fw)
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0"KernelACPIVersion",
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0"Cannot get ACPI version info from /sys/module/acpi/parameters/ac=
pica_version or /proc/acpi/info");
> =C2=A0 =C2=A0 =C2=A0 =C2=A0else {
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 fwts_chop_newline(str)=
;
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0fwts_passed(fw, "A=
CPI Version: %s", str);
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0free(str);
> =C2=A0 =C2=A0 =C2=A0 =C2=A0}
> --
> 1.7.10
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>


[prev in list] [next in list] [prev in thread] [next in thread]