[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fwknop-discuss
Subject:    [Fwknop-discuss] Fwknop 1.9.8 pre3
From:       Franck Joncourt <franck.mail () dthconnex ! com>
Date:       2008-09-29 20:35:56
Message-ID: 48E13C2C.3070207 () dthconnex ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


Hi all,

I have enclosed two patches against fwknop 1.9.8 pre3:

  - fwknopd_manpage.diff: fixed a lintian warning (hyphen)
  - fwknopd_cmds: fixed the check_command function or at least I think so

The second one prevents me from releasing the debian package tonight
from the dthconnex repository. I need to add some functionalities in the
packaging (quilt).

Check the patches for a more detailed explanation :)

However, I have built the package with the above patches for tests only.

Francois, if you want to check this release, just run the following
commands:

[code]
dget http://www.dthconnex.com/packages/fwknop_1.9.8+svn.pre3-1.dsc
dpkg-source -x http://www.dthconnex.com/packages/fwknop_1.9.8+svn.pre3-1.dsc
[/code]

Then build the package, or run the test suite.

The test suite runs fine on two systems with my usual ruleset, however I
have been able to make it fail with the one I am currently working on.
I will try to understand why later.

Hope it helps,

-- 
Franck Joncourt
http://debian.org - http://smhteam.info/wiki/
Fingerprint : C10E D1D0 EF70 0A2A CACF 9A3C C490 534E 75C0 89FE

["fwknopd_cmds.diff" (text/x-diff)]

From: Franck Joncourt <franck.mail@dthconnex.com>
Subject: [PATCH] fixes/fwknopd_cmds

Allow fwknopd to search for commands in common directories.

  On Debian systems the mail command is not located at /bin/mail, but at
  /usr/bin/mail. The current include check in the check_commands function
  prevents the daemon from searching for a command, unless it can be found
  in the include variable.

Signed-off-by: Franck Joncourt <franck.mail@dthconnex.com>

---
 fwknopd |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fwknopd b/fwknopd
index 1ca0c9e..86cb6f3 100755
--- a/fwknopd
+++ b/fwknopd
@@ -4053,7 +4053,7 @@ sub check_commands() {
     for my $cmd (keys %cmds) {
 
         if ($include_hr) {
-            next unless defined $include_hr->{$cmd};
+            next unless not defined $include_hr->{$cmd};
         }
         if ($exclude_hr) {
             next if defined $exclude_hr->{$cmd};
-- 
tg: (2fa06ac..) fixes/fwknopd_cmds (depends on: upstream)

["fwknopd_manpage.diff" (text/x-diff)]

From: Franck Joncourt <franck.mail@dthconnex.com>
Subject: [PATCH] fixes/fwknopd_manpage

Hyphen used as minus sign found in fwknopd.8


  This fixes the following lintian warning about fwknopd manpage:
  http://lintian.debian.org/tags/hyphen-used-as-minus-sign.html

Signed-off-by: Franck Joncourt <franck.mail@dthconnex.com>

---
 fwknopd.8 |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fwknopd.8 b/fwknopd.8
index 4fe423d..232b2ab 100644
--- a/fwknopd.8
+++ b/fwknopd.8
@@ -225,7 +225,7 @@ mode, then this option can be useful to ensure that encrypted SPA data is sent
 through the GnuPG decryption routine.  The 'hQ' prefix is a heuristic derived from
 the file 'magic' database for describing data encrypted with GnuPG, and the fwknop
 client normally strips this data from outgoing SPA packets (unless the
---Include-gpg-prefix option is used).
+\-\-Include-gpg-prefix option is used).
 .TP
 .B GPG_PATH: <path>
 Specify a path to the gpg binary (commonly at /usr/bin/gpg).  This can be used to
-- 
tg: (2fa06ac..) fixes/fwknopd_manpage (depends on: upstream)

["signature.asc" (application/pgp-signature)]

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/

_______________________________________________
Fwknop-discuss mailing list
Fwknop-discuss@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/fwknop-discuss


[prev in list] [next in list] [prev in thread] [next in thread]