[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fuse-devel
Subject:    Re: [fuse-devel] [PATCH 1/1] fuse-2.7.2 add option for
From:       Miklos Szeredi <miklos () szeredi ! hu>
Date:       2009-08-04 10:49:05
Message-ID: E1MYHZp-0004Bh-I8 () pomaz-ex ! szeredi ! hu
[Download RAW message or body]

On Fri, 17 Jul 2009, Mike Morrison wrote:
> Miklos Szeredi <miklos@...> writes:
> > > Add POSIX ACL checking to the default_permissions checking when
> > > the option acl is used (assuming the filesystem supports
> > > xattrs).
> > 
> > Thanks, looks good.
> > 
> > Patch looks whitespace damaged, however.  Some info about avoiding
> > this:
> 
> Sorry to fire up the wayback machine here, but in searching the list
> archives for ACLs info, I found this patch submission from Jan 2008
> that adds an ACL check callback to the generic_permission call.
> 
> Full thread link: 
>   http://thread.gmane.org/gmane.comp.file-systems.fuse.devel/5651 
>   
> Was there anything wrong with this patch other than the spacing? If
> not, would this still be a viable change (re-patched to current
> kernel, of course)?

The patch looks mostly OK.  Always doing two getxattr calls seems like
a pretty big waste, though.

The POSIX_ACL flag is also now being used for a related but different
thing, so these two uses will need to be consolidated.

Thanks,
Miklos

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
fuse-devel mailing list
fuse-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/fuse-devel
[prev in list] [next in list] [prev in thread] [next in thread]