[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fstests
Subject:    Re: [PATCH v3] tests: _fail on _scratch_mkfs_sized failure
From:       David Disseldorp <ddiss () suse ! de>
Date:       2024-04-30 0:25:02
Message-ID: 20240430102502.3167c16a () echidna
[Download RAW message or body]

On Tue, 30 Apr 2024 03:02:44 +0800, Zorro Lang wrote:

> On Mon, Apr 29, 2024 at 09:05:16AM -0700, Darrick J. Wong wrote:
...
> > > +_scratch_mkfs_sized()
> > > +{
> > > +	_try_scratch_mkfs_sized $* || _fail "_scratch_mkfs_sized (size=${1}) failed"  
> > 
> > I wonder if you ought to dump all the arguments, but the maintainer did
> > say to print the *size*. :)  
> 
> Sorry I didn't say that clearly, I mean the arguments related with size :-D

No worries :) I'm fine with it either way.

> 
> If both of you don't have more suggestions, I can help to change this line to:
> 
> _try_scratch_mkfs_sized $* || \
> 	_fail "_scratch_mkfs_sized failed with ($*)"
> 
> when I merge it.

Sure, works for me.

Cheers, David

[prev in list] [next in list] [prev in thread] [next in thread]