[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fstests
Subject:    Re: [PATCH 2/2] mm/huge_memory: cap max length on debugfs file entry folio split
From:       Zi Yan <ziy () nvidia ! com>
Date:       2024-04-25 1:05:04
Message-ID: AB2FFCD8-6A5B-4E0B-BFE1-4EACC996CA22 () nvidia ! com
[Download RAW message or body]

On 24 Apr 2024, at 18:54, Luis Chamberlain wrote:

> Don't allow to query beyond a mapped file's length. Since this is just
> a debugfs interface allow userspace to be lazy and use a large value so
> we can just use the entire file.
>
> Without this we can end up wasting cycles looking for folios which
> just don't exist for no good reason.
>
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> ---
>  mm/huge_memory.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index 8386d24a163e..86a8c7b3b8dc 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -3535,7 +3535,7 @@ static int split_huge_pages_in_file(const char *file_path, pgoff_t off_start,
>  	struct file *candidate;
>  	struct address_space *mapping;
>  	int ret = -EINVAL;
> -	pgoff_t index;
> +	pgoff_t index, fsize;
>  	int nr_pages = 1;
>  	unsigned long total = 0, split = 0;
>
> @@ -3547,11 +3547,14 @@ static int split_huge_pages_in_file(const char *file_path, pgoff_t off_start,
>  	if (IS_ERR(candidate))
>  		goto out;
>
> +	mapping = candidate->f_mapping;
> +	fsize = i_size_read(mapping->host);
> +	if (off_end > fsize)
> +		off_end = fsize;
> +
>  	pr_debug("split file-backed THPs in file: %s, page offset: [0x%lx - 0x%lx]\n",
>  		 file_path, off_start, off_end);
>
> -	mapping = candidate->f_mapping;
> -
>  	for (index = off_start; index < off_end; index += nr_pages) {
>  		struct folio *folio = filemap_get_folio(mapping, index);

LGTM. Reviewed-by: Zi Yan <ziy@nvidia.com>

--
Best Regards,
Yan, Zi

["signature.asc" (signature.asc)]

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmYprEAPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUoa0QAJFvYFTTzizyPC8tlq87XYVxqPXn+BTz6K1B
m86NEIR3LxM59xEwGbmT/ReMR628Qs4nj9S86v5WGN09NaPyArNQcOoW9PR9NZD0
II/ldsGg7U7xrev80vfyRIQ+VUZutz8Oaoe41OfmGAMrp/5S2Kpz73knf2Zxd7KN
M71TQlzwJntdx+XK+alQnJj4UcgyMq3HMvA6Yr2lmgQ85Et7LWrCgo5W3oovz+n5
kB57Y2JFZyZkaDKZKJIM4M7LYSuvJYxrjMVLQZi5pETSgfYYZwlul2br+KXrlAAP
suV+K+VyWsTZ0rgQCHHZx1v4DLH2EBbkqQKLOfyPu/+m7PuxsKCAhTvh4PAMSz3h
UvpcYLYVPWh0dsDHPhhGp7+cABwahwAsT6HC5/MfnZepBbvrHRIs+MJIpO1fv+mi
qF7p7MBfwyKXSueS7MnYfEFqiQBoZNoh0PfJ7Hvw54YrzSy5uqgPr7PpZorw/mkX
fj0+dgyQOJZ63FAb9pq+veqT2kCqAp9IGMnPsnZ3UWx9M0l+XlRSljhZ1IEYt+UB
2aC4kkWhyBFxQ3Y2XmUXR5quI2uifBeX8jLxOwuOUf1yNEIsXVLKvUPaWrDI4dH7
r4H3/o1r+bgLhU0ZRjqdYvAy7CpauZcQNL0Z2Rt/FArZ1ph/QKB8JfgHaLKDhY7B
8WPHmg6D
=CPe/
-----END PGP SIGNATURE-----


[prev in list] [next in list] [prev in thread] [next in thread]