[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fstests
Subject:    Re: [PATCH 01/12] common/encrypt: separate data and inode nonces
From:       Anand Jain <anand.jain () oracle ! com>
Date:       2023-10-31 14:13:39
Message-ID: 6e202446-46d4-4db3-7620-d20b7d22b512 () oracle ! com
[Download RAW message or body]

On 11/10/2023 04:25, Josef Bacik wrote:
> From: Sweet Tea Dorminy <sweettea-kernel@dorminy.me>
> 
> btrfs will have different inode and data nonces, so we need to be
> specific about which nonce each use needs. For now, there is no
> difference in the two functions.
> 
> Signed-off-by: Sweet Tea Dorminy <sweettea-kernel@dorminy.me>
> ---
Looks good.

Reviewed-by: Anand Jain <anand.jain@oracle.com>

And, as Eric pointed out, the naming can be more intuitive. Keywords 
such as 'inode' and 'extent' will make them more intuitive, rather than 
'file' and 'data,' IMO.

Thanks, Anand


[prev in list] [next in list] [prev in thread] [next in thread]