[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fstests
Subject:    Re: [PATCH v5 3/3] generic/471: add syncfs test
From:       Amir Goldstein <amir73il () gmail ! com>
Date:       2018-08-26 14:53:33
Message-ID: CAOQ4uxgf=btK-MKed7-8_nmpfO-UnPyVJ4RyTtK1hMQuU8Y=-g () mail ! gmail ! com
[Download RAW message or body]

On Fri, Dec 15, 2017 at 9:48 AM Chengguang Xu <cgxu519@icloud.com> wrote:
>
> Inspired by syncfs bug of overlayfs which does not sync dirtyinodes in
> underlying filesystem.
> Run syncfs and shutdown filesystem(or underlying filesystem of overlayfs)
> to check syncfs result.
>
> Signed-off-by: Chengguang Xu <cgxu519@icloud.com>
> ---

Hi Chengguang,

I just noticed that this test (now generic/474) is skipped for overlay over ext4
for a strange looking reason - it seems that in the overlay_mount() call from
_scratch_cycle_mount() the function hits
_notrun "upper fs needs to support d_type".

This doesn't happen on my test system with overlay over xfs.
Did you happen to test this with overlay over ext4 at the time?
Will you have time to look into this?

Thanks,
Amir.
[prev in list] [next in list] [prev in thread] [next in thread]