[prev in list] [next in list] [prev in thread] [next in thread]
List: fstests
Subject: [PATCH] statx: correct error handling of NULL pathname
From: "Michael Kerrisk (man-pages)" <mtk.manpages () gmail ! com>
Date: 2017-04-27 11:54:11
Message-ID: d10d318c-7461-96fb-952b-c246811a8228 () gmail ! com
[Download RAW message or body]
The change in 1e2f82d1e9d1 to error on a NULL pathname to statx()
is inconsistent. It results in the error EINVAL for a NULL pathname.
Consistent with similar APIs (fchownat(), fstatat(), linkat()),
the error should be EFAULT.
The solution is simply to remove the EINVAL check. As I already
pointed out in https://lkml.org/lkml/2017/4/26/561, user_path_at*()
and filename_lookup() will handle the NULL pathname as per
the other APIs, to correctly produce the error EFAULT.
Signed-off-by: Michael Kerrisk <mtk.manpages@gmail.com>
---
fs/stat.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/stat.c b/fs/stat.c
index 3d85747..a257b87 100644
--- a/fs/stat.c
+++ b/fs/stat.c
@@ -567,8 +567,6 @@ SYSCALL_DEFINE5(statx,
return -EINVAL;
if ((flags & AT_STATX_SYNC_TYPE) == AT_STATX_SYNC_TYPE)
return -EINVAL;
- if (!filename)
- return -EINVAL;
error = vfs_statx(dfd, filename, flags, &stat, mask);
if (error)
--
2.5.5
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic