[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fstests
Subject:    Re: [PATCH v2] overlay: notrun if upper fs does not support d_type
From:       Eryu Guan <eguan () redhat ! com>
Date:       2016-04-22 10:24:53
Message-ID: 20160422102453.GJ4675 () eguan ! usersys ! redhat ! com
[Download RAW message or body]

On Fri, Apr 22, 2016 at 05:21:51PM +0800, Xiong Zhou wrote:
> Overlayfs whiteout can be visible if underlying upper fs does not
> support d_type. Kernel commit
> 	45aebea (ovl: Ensure upper filesystem supports d_type)
> prevents mounting overlayfs like this since v4.6-rc1.
> 
> Check upper fs before mounting overlay, mark as not run if needs.
> 
> Signed-off-by: Xiong Zhou <xzhou@redhat.com>

I'm not sure if this really necessary, but looks fine to me.

Reviewed-by: Eryu Guan <eguan@redhat.com>
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]