[prev in list] [next in list] [prev in thread] [next in thread]
List: freetype-devel
Subject: Re: [ft-devel] [GSoC'19] ftinspect update
From: Triplex <veekiyadav () gmail ! com>
Date: 2019-08-08 10:18:01
Message-ID: CAAvmodSRhLLpFYUjnDCbs8c3_bVh43WqitVEevwZJHDsM7Yn6g () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hi Werner,
Thanks for the descriptive feedback and I'll make sure to
fix the issues ASAP.
> * The biggest problem is that glyphs in the `ftview' mode aren't
> displayed with correct vertical positions. This is serious bug and
> must be fixed ASAP – I think I reported this already six weeks
> ago...
>
This actually is a problem. I tried some ways to fix the same. I'll
try fixing the same ASAP.
* I don't like that there are tabs called `Ftview' or `Ftdiff'; a new
> user has no idea what this is for. Instead, if you select one of
> the `modes' with the radio buttons, the tabs on the left side should
> change according to the mode (having functional names that helps the
> user in navigation), and/or features that don't fit should be greyed
> out.
>
I think you must have compiled the program from 'gsoc-2019-experimental'
branch. It's not completely updated. For the same reason I attached a small
introduction video.
So, options have been properly grayed out and tabs also have functional
names now.
Another issue is that selecting stuff from the tab suddenly changes
> the mode; for example, if I select `Grid View', then `Ftview->Render
> Mode->Stroked', the display no longer is in grid mode (but the radio
> button still shows it). This must not happen. As mentioned above,
> options that do not fit a mode must be disabled (or not displayed).
>
This also have been done.
* If a dark desktop theme gets used, the background of the main window
> becomes dark, too. This is quite bad, since the various gray shades
> are no longer displayed correctly. Please ensure that always a
> white background gets used.
>
This part I haven't had a look at. I'll make sure to fix it.
* `Segment Drawing' doesn't work correctly. Segment lines appear for
> half a second, then they disappear again. Additionally, it seems
> that if both horizontal and vertical auto-hinting is selected, even
> the short appearance can't be triggered.
>
This is not the case now. It works as it is expected to work.
By the way, the segment lines are too thick now. If the grid line
> has a thickness of 1px, I suggest that segment lines are 2px thick
> (i.e., ½px + 1px + ½px).
>
Sure! I'll make it a quick fix.
>
> * The `All Glyphs' mode is mostly dysfunctional. For example, the
> display doesn't get updated if I select auto-hinting.
Thanks for pointing out. I just noticed it. It was because of wrong
functional
call.
Similarly,
> pressing the `+10' button (and friends) only adjusts a single, red
> outlined glyph that is always positioned in the center – what is
> this good for?
That was supposed to be disabled while changing to 'All Glyphs' and
now it is disable as soon as we change to other modes. Same goes for
'+10' button (and friends).
* Another issue with the `All Glyphs' mode: If I select a large size
> (say, 100px), I can't move the image around with my mouse. Ditto
> for `Comparator' mode.
>
I disabled the drag mode in those modes. Since, everything
that was supposed to be viewed was displayed within the given
area. I didn't go through the possibility of changing pixel sizes in
these modes. Should I enable it back? And handle larger size in those
modes too?
* If I select a large size in `All Glyphs' mode, then select `Grid
> View' the size gets respected. However, selecting `All Glyphs' mode
> again, the size jumps back to a default size of 20px.
>
This is also on purpose. Because otherwise user had to scroll over the
canvas to search for the results if the size is too large. Thus changing the
size makes it easy to notice the mode change.
* All modes except `Grid View' mode lag a lot if I change parameters,
> or if I move the panel with the mouse – this indicates a problem
> with the implementation. Please fix that. It must work as swift as
> the `Grid View' mode.
>
I'll see to that. Thanks for pointing it out.
* Please display number values on the Gamma scale (i.e., using a
> different widget for the scale).
>
Noted.
* The Gamma scale behaves strangely: selecting values at the very
> left, the image be brighter again! This can't be correct.
>
Yeah, I guess. Although I followed the below solution to achieve the current
implementation
<https://stackoverflow.com/questions/53153300/image-gamma-corection-in-qt>.
> * Gamma values should work in all modes, not only `Grid View'.
>
That is also completed.
Thank you for pointing out all the issues with details. I'll make sure
to resolve all ASAP.
--
Veeki
[Attachment #5 (text/html)]
<div dir="ltr"><div dir="ltr"><div dir="ltr">Hi Werner,</div><div \
dir="ltr"><br></div><div>Thanks for the descriptive feedback and I'll make sure \
to</div><div>fix the issues ASAP.</div><div> <br></div><div \
class="gmail_quote"><span class="gmail-im" style="color:rgb(80,0,80)"><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">* The biggest problem is that glyphs in the \
`ftview' mode aren't<br> displayed with correct vertical positions. This \
is serious bug and<br> must be fixed ASAP – I think I reported this already six \
weeks<br> ago...<br></blockquote><div> <br></div></span><div>This actually is a \
problem. I tried some ways to fix the same. I'll</div><div>try fixing the same \
ASAP.</div><span class="gmail-im" \
style="color:rgb(80,0,80)"><div><br></div><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">* I don't like that there are tabs called \
`Ftview' or `Ftdiff'; a new<br> user has no idea what this is for. \
Instead, if you select one of<br> the `modes' with the radio buttons, the tabs \
on the left side should<br> change according to the mode (having functional names \
that helps the<br> user in navigation), and/or features that don't fit should \
be greyed<br> out.<br></blockquote><div><br></div></span><div>I think you must have \
compiled the program from 'gsoc-2019-experimental'</div><div>branch. It's \
not completely updated. For the same reason I attached a small</div><div>introduction \
video. </div><div>So, options have been properly grayed out and tabs also have \
functional</div><div>names now. <br></div><span class="gmail-im" \
style="color:rgb(80,0,80)"><div><br></div><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">Another issue is that selecting stuff from the tab \
suddenly changes<br> the mode; for example, if I select `Grid View', then \
`Ftview->Render<br> Mode->Stroked', the display no longer is in grid mode \
(but the radio<br> button still shows it). This must not happen. As mentioned \
above,<br> options that do not fit a mode must be disabled (or not \
displayed).<br></blockquote><div><br></div></span><div>This also have been done. \
</div><span class="gmail-im" style="color:rgb(80,0,80)"><div><br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">* If a dark desktop theme gets used, the \
background of the main window<br> becomes dark, too. This is quite bad, since the \
various gray shades<br> are no longer displayed correctly. Please ensure that \
always a<br> white background gets \
used.<br></blockquote><div><br></div></span><div>This part I haven't had a look \
at. I'll make sure to fix it. </div><span class="gmail-im" \
style="color:rgb(80,0,80)"><div><br></div><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">* `Segment Drawing' doesn't work \
correctly. Segment lines appear for<br> half a second, then they disappear again. \
Additionally, it seems<br> that if both horizontal and vertical auto-hinting is \
selected, even<br> the short appearance can't be \
triggered.<br></blockquote><div><br></div></span><div>This is not the case now. It \
works as it is expected to work. </div><span class="gmail-im" \
style="color:rgb(80,0,80)"><div><br></div><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"> By the way, the segment lines are too thick \
now. If the grid line<br> has a thickness of 1px, I suggest that segment lines \
are 2px thick<br> (i.e., ½px + 1px + \
½px).<br></blockquote><div><br></div></span><div>Sure! I'll make it a quick fix. \
</div><span class="gmail-im" style="color:rgb(80,0,80)"><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><br>* The `All Glyphs' mode is mostly \
dysfunctional. For example, the<br> display doesn't get updated if I select \
auto-hinting.</blockquote><div> </div></span><div>Thanks for pointing out. I just \
noticed it. It was because of wrong functional</div><div>call.</div><span \
class="gmail-im" style="color:rgb(80,0,80)"><div><br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">Similarly,<br> pressing the `+10' button \
(and friends) only adjusts a single, red<br> outlined glyph that is always \
positioned in the center – what is<br> this good for?</blockquote><div> \
</div></span><div>That was supposed to be disabled while changing to 'All \
Glyphs' and</div><div>now it is disable as soon as we change to other modes. Same \
goes for</div><div>'+10' button (and friends).</div><span class="gmail-im" \
style="color:rgb(80,0,80)"><div><br></div><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">* Another issue with the `All Glyphs' mode: If \
I select a large size<br> (say, 100px), I can't move the image around with my \
mouse. Ditto<br> for `Comparator' \
mode.<br></blockquote><div><br></div></span><div>I disabled the drag mode in those \
modes. Since, everything</div><div>that was supposed to be viewed was displayed \
within the given</div><div>area. I didn't go through the possibility of changing \
pixel sizes in</div><div>these modes. Should I enable it back? And handle larger size \
in those</div><div>modes too?</div><span class="gmail-im" \
style="color:rgb(80,0,80)"><div><br></div><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">* If I select a large size in `All Glyphs' \
mode, then select `Grid<br> View' the size gets respected. However, selecting \
`All Glyphs' mode<br> again, the size jumps back to a default size of \
20px.<br></blockquote><div><br></div></span><div>This is also on purpose. Because \
otherwise user had to scroll over the</div><div>canvas to search for the results if \
the size is too large. Thus changing the</div><div>size makes it easy to notice the \
mode change.</div><span class="gmail-im" \
style="color:rgb(80,0,80)"><div><br></div><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">* All modes except `Grid View' mode lag a lot \
if I change parameters,<br> or if I move the panel with the mouse – this \
indicates a problem<br> with the implementation. Please fix that. It must work \
as swift as<br> the `Grid View' mode.<br></blockquote><div> \
</div></span><div>I'll see to that. Thanks for pointing it out.</div><span \
class="gmail-im" style="color:rgb(80,0,80)"><div><br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">* Please display number values on the Gamma scale \
(i.e., using a<br> different widget for the \
scale).<br></blockquote><div><br></div></span><div>Noted. </div><span \
class="gmail-im" style="color:rgb(80,0,80)"><div><br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">* The Gamma scale behaves strangely: selecting \
values at the very<br> left, the image be brighter again! This can't be \
correct.<br></blockquote><div><br></div></span><div>Yeah, I guess. Although I \
followed the below solution to achieve the current</div><div><a \
href="https://stackoverflow.com/questions/53153300/image-gamma-corection-in-qt" \
target="_blank">implementation</a>.</div><span class="gmail-im" \
style="color:rgb(80,0,80)"><div> </div><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">* Gamma values should work in all modes, not only \
`Grid View'.<br></blockquote><div><br></div></span><div>That is also completed. \
</div><div><br></div><div>Thank you for pointing out all the issues with details. \
I'll make sure</div><div>to resolve all ASAP.</div></div></div><div><br></div>-- \
<br><div dir="ltr" class="gmail_signature"><div dir="ltr">Veeki</div></div></div>
[Attachment #6 (text/plain)]
_______________________________________________
Freetype-devel mailing list
Freetype-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/freetype-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic