[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freetype-devel
Subject:    Re: [Devel] jump-to-0 exception in FTC_MruList_RemoveSelection()
From:       Werner LEMBERG <wl () gnu ! org>
Date:       2004-03-20 19:10:34
Message-ID: 20040320.201034.165113912.wl () gnu ! org
[Download RAW message or body]


> The (only) caller to FTC_MruList_RemoveSelection() is
> FTC_Manager_RemoveFaceID(),

And ftc_face_node_done (in ftcmanag.c).

> which passes a NULL selection procedure pointer, but
> FTC_MruList_RemoveSelection() doesn't check for this.
>
> Since I realize that the FT Cache is a work in progress, I can't be
> sure whether FTC_MruList_RemoveSelection() should be changed to
> supply a non-NULL proc pointer, so for the time being I have changed
> FTC_MruList_RemoveSelection() to treat a NULL proc pointer as
> 'select all'.

I've applied your fix since it seems to me the right thing.  David,
please check this.  Thanks!


    Werner

_______________________________________________
Devel mailing list
Devel@freetype.org
http://www.freetype.org/mailman/listinfo/devel
[prev in list] [next in list] [prev in thread] [next in thread]