[prev in list] [next in list] [prev in thread] [next in thread]
List: freeswitch-dev
Subject: Re: [Freeswitch-dev] FS-2877 patch
From: Anthony Minessale <anthony.minessale () gmail ! com>
Date: 2011-10-24 14:40:26
Message-ID: CAKbxfG8sZe78Nig1qrbc_=3BSjDneBqtXGGGV-1O_e8KLNFRCA () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
got it, thx
On Mon, Oct 24, 2011 at 8:55 AM, Beeton, Carolyn (Carolyn) <
cbeeton@avaya.com> wrote:
> **
> Anthony,
>
> I see that the patch from FS-2877 has been committed (thanks! I hope it
> helps to address the BLF issues others have seen). I did have a comment on
> that issue that there was a typo in the patch which I don't think was
> corrected in the commit. The typo will cause the database to be dropped and
> rebuilt on every run. This would fix it:
>
> diff --git a/src/mod/endpoints/mod_sofia/sofia_glue.c
> b/src/mod/endpoints/mod_sofia/sofia_glue.c
> index e6076e8..a6de2f5 100644
> --- a/src/mod/endpoints/mod_sofia/sofia_glue.c
> +++ b/src/mod/endpoints/mod_sofia/sofia_glue.c
> @@ -5974,7 +5974,7 @@ int sofia_glue_init_sql(sofia_profile_t *profile)
> switch_cache_db_test_reactive(dbh, test_sql, "DROP TABLE
> sip_subscriptions", sub_sql);
>
> free(test_sql);
> - test_sql = switch_mprintf("delete from sip_dialogs where hostname='%q'
> and expires <> -9999 or rpid='' or from_tag=''",
> mod_sofia_globals.hostname);
> + test_sql = switch_mprintf("delete from sip_dialogs where hostname='%q'
> and expires <> -9999 or rpid='' or sip_from_tag=''",
> mod_sofia_globals.hostname);
>
>
> switch_cache_db_test_reactive(dbh, test_sql, "DROP TABLE sip_dialogs",
> dialog_sql);
>
>
> Carolyn
>
> _______________________________________________
> Join us at ClueCon 2011, Aug 9-11, Chicago
> http://www.cluecon.com 877-7-4ACLUE
>
> FreeSWITCH-dev mailing list
> FreeSWITCH-dev@lists.freeswitch.org
> http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev
> UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-dev
> http://www.freeswitch.org
>
>
--
Anthony Minessale II
FreeSWITCH http://www.freeswitch.org/
ClueCon http://www.cluecon.com/
Twitter: http://twitter.com/FreeSWITCH_wire
AIM: anthm
MSN:anthony_minessale@hotmail.com
GTALK/JABBER/PAYPAL:anthony.minessale@gmail.com
IRC: irc.freenode.net #freeswitch
FreeSWITCH Developer Conference
sip:888@conference.freeswitch.org
googletalk:conf+888@conference.freeswitch.org
pstn:+19193869900
[Attachment #5 (text/html)]
got it, thx<br><br><div class="gmail_quote">On Mon, Oct 24, 2011 at 8:55 AM, Beeton, \
Carolyn (Carolyn) <span dir="ltr"><<a \
href="mailto:cbeeton@avaya.com">cbeeton@avaya.com</a>></span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex;"> <u></u>
<div>
<div><span><font face="Arial" size="2">Anthony,</font></span></div>
<div><span><font face="Arial" size="2"></font></span> </div>
<div><span><font face="Arial" size="2">I see that the patch
from FS-2877 has been committed (thanks! I hope it helps to address the
BLF issues others have seen). I did have a comment on that issue that
there was a typo in the patch which I don't think was corrected in the
commit. The typo will cause the database to be dropped and rebuilt on
every run. This would fix it:</font></span></div>
<div><span><font face="Arial" size="2"></font></span> </div>
<div><span><font face="Arial" size="2">diff --git
a/src/mod/endpoints/mod_sofia/sofia_glue.c
b/src/mod/endpoints/mod_sofia/sofia_glue.c<br>index e6076e8..a6de2f5
100644<br>--- a/src/mod/endpoints/mod_sofia/sofia_glue.c<br>+++
b/src/mod/endpoints/mod_sofia/sofia_glue.c<br>@@ -5974,7 +5974,7 @@ int
sofia_glue_init_sql(sofia_profile_t
*profile)<br> switch_cache_db_test_reactive(dbh, test_sql, "DROP
TABLE sip_subscriptions",
sub_sql);<br> <br> free(test_sql);<br>- test_sql =
switch_mprintf("delete from sip_dialogs where hostname='%q' and expires \
<>
-9999 or rpid='' or from_tag=''",
mod_sofia_globals.hostname);<br>+ test_sql = switch_mprintf("delete from
sip_dialogs where hostname='%q' and expires <> -9999 or rpid='' \
or sip_from_tag=''",
mod_sofia_globals.hostname);<br> <br> <br> switch_cache_db_test_reactive(dbh,
test_sql, "DROP TABLE sip_dialogs", dialog_sql);</font></span></div>
<div><span><font face="Arial" size="2"></font></span> </div><font color="#888888">
<div><span><font face="Arial" size="2"></font></span> </div>
<div><span><font face="Arial" size="2">Carolyn</font></span></div></font></div>
<br>_______________________________________________<br>
Join us at ClueCon 2011, Aug 9-11, Chicago<br>
<a href="http://www.cluecon.com" target="_blank">http://www.cluecon.com</a> \
877-7-4ACLUE<br> <br>
FreeSWITCH-dev mailing list<br>
<a href="mailto:FreeSWITCH-dev@lists.freeswitch.org">FreeSWITCH-dev@lists.freeswitch.org</a><br>
<a href="http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev" \
target="_blank">http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev</a><br> \
UNSUBSCRIBE:<a href="http://lists.freeswitch.org/mailman/options/freeswitch-dev" \
target="_blank">http://lists.freeswitch.org/mailman/options/freeswitch-dev</a><br> <a \
href="http://www.freeswitch.org" target="_blank">http://www.freeswitch.org</a><br> \
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br>Anthony Minessale \
II<br><br>FreeSWITCH <a \
href="http://www.freeswitch.org/">http://www.freeswitch.org/</a><br>ClueCon <a \
href="http://www.cluecon.com/">http://www.cluecon.com/</a><br>
Twitter: <a href="http://twitter.com/FreeSWITCH_wire">http://twitter.com/FreeSWITCH_wire</a><br><br>AIM: \
anthm<br><a href="mailto:MSN%3Aanthony_minessale@hotmail.com">MSN:anthony_minessale@hotmail.com</a><br>GTALK/JABBER/<a \
href="mailto:PAYPAL%3Aanthony.minessale@gmail.com">PAYPAL:anthony.minessale@gmail.com</a><br>
IRC: <a href="http://irc.freenode.net">irc.freenode.net</a> \
#freeswitch<br><br>FreeSWITCH Developer Conference<br><a \
href="mailto:sip%3A888@conference.freeswitch.org">sip:888@conference.freeswitch.org</a><br><a \
href="mailto:googletalk%3Aconf%2B888@conference.freeswitch.org">googletalk:conf+888@conference.freeswitch.org</a><br>
pstn:+19193869900<br>
_______________________________________________
Join us at ClueCon 2011, Aug 9-11, Chicago
http://www.cluecon.com 877-7-4ACLUE
FreeSWITCH-dev mailing list
FreeSWITCH-dev@lists.freeswitch.org
http://lists.freeswitch.org/mailman/listinfo/freeswitch-dev
UNSUBSCRIBE:http://lists.freeswitch.org/mailman/options/freeswitch-dev
http://www.freeswitch.org
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic