[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freeradius-users
Subject:    Re: select() error about freeradius-0.4
From:       "Miquel van Smoorenburg" <miquels () cistron ! nl>
Date:       2002-01-31 12:56:59
[Download RAW message or body]

In article <20020130164258.X29096@google.com>,
Frank Cusack  <fcusack@fcusack.com> wrote:
>On Tue, Jan 29, 2002 at 11:26:05PM +0000, Miquel van Smoorenburg wrote:
>> It can get worse. If you close(STDOUT_FILENO) and/or STDERR_FILENO,
>> then the next open will get fd#1 or fd#2. That could be your SQL
>> socket, or whatever. Now anything that calls printf() or perror()
>> or something (some libc routines do! yuck!) will write to a random
>> filedescriptor.
>
>The well behaved daemon closes existing open file descriptors.  If your
>daemon calls code that would do perror(), etc. it is buggy.

But sometimes the C library does this. Especially the NIS code sometimes
prints 'cannot bind to YP server' or something similar.

Yes, that is buggy. But you have to take it into account.

>Given that freeradius has exec-program-wait, it probably should close these
>and reopen them /dev/null (unless -X).

But that is what this thread is about. It has been fixed that way
in CVS a day ago by Alan.

Mike.



[prev in list] [next in list] [prev in thread] [next in thread]