[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freeradius-devel
Subject:    Re: Re: Re: Re: proxy question
From:       Liyan Tan <tanliyan () 263 ! net>
Date:       2003-05-29 0:17:27
[Download RAW message or body]

since realm_find() and proxy_realm_ldb() would find two different REALM struct, so \
they should all have the same configureations, at least "nostrip" and "LOCAL" should \
be the same. (several parameters like  "noacct", "norealm", "notsuffix" are for what \
use?)

proposed patch:

@@ -497,18 +499,7 @@
        for(c = mainconfig.realms; c != NULL; c = c->next) {
                REALM *this;
 
-               /*
-                *      Check that we cannot load balance to LOCAL
-                *      realms, as that doesn't make any sense.
-                */
-               if ((c->ldflag == 1) &&
-                   ((c->ipaddr == htonl(INADDR_NONE)) ||
-                    (c->acct_ipaddr == htonl(INADDR_NONE)))) {
-                       radlog(L_ERR | L_CONS, "ERROR: Realm %s cannot be load \
                balanced to LOCAL",
-                              c->realm);
-                       exit(1);
-               }
-
+
                /*
                 *      Compare this realm to all others, to ensure
                 *      that the configuration is consistent.
@@ -527,6 +518,23 @@
                                       c->realm);
                                exit(1);
                        }
+                       if(c->striprealm != this->striprealm){
+                               radlog(L_ERR | L_CONS, "ERROR: Inconsistent value in \
realm %s for 'nostrip' attribute", +                                                  \
c->realm); +                               exit(1);
+                       }
+                       if( ((c->ipaddr == htonl(INADDR_NONE)) && (this->ipaddr != \
htonl(INADDR_NONE))) || +                           ((c->ipaddr != \
htonl(INADDR_NONE)) && (this->ipaddr == htonl(INADDR_NONE))) ){ +                     \
radlog(L_ERR | L_CONS, "ERROR: Inconsistent config in realm %s , one is configed \
LOCAL auth, another is REMOTE", +                                                     \
c->realm); +                               exit(1);
+                       }
+                       if( ((c->acct_ipaddr == htonl(INADDR_NONE)) && \
(this->acct_ipaddr != htonl(INADDR_NONE))) || +                           \
((c->acct_ipaddr != htonl(INADDR_NONE)) && (this->acct_ipaddr == htonl(INADDR_NONE))) \
){ +                               radlog(L_ERR | L_CONS, "ERROR: Inconsistent config \
in realm %s , one is configed LOCAL acct, another is REMOTE", +                       \
c->realm); +                                exit(1);
+                        }
                }
        }
 

    Liyan Tan
    tanliyan@263.net
	2003-05-29 



- 
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/devel.html


[prev in list] [next in list] [prev in thread] [next in thread]