[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freenx-knx
Subject:    [FreeNX-kNX] freenx-client 0.9 feedback
From:       Dirk Mueller <mueller () kde ! org>
Date:       2008-04-10 10:08:08
Message-ID: 200804101208.08292.mueller () kde ! org
[Download RAW message or body]

Hi, 

some feedback from trying to build freenx-client 0.9 release:

a) it does not build with gcc 4.3. see attached patch

b) qtnx can still not install itself. see other attached patch

c) as qtnx needs pkgconfig to resolve the libnxcl, which is built in the other 
subdir, I think it would cause less pain for the packagers of those two sub 
directory would be separated in different tarballs. They don't share a common 
build system anyway. 

d) the source code claims to be GPL v2+. GPL however requires to ship a GPL 
license in a file named COPYING as part of the package. this doesn't seem to 
be the case. Please clarify the actual license of the code. Also, list of 
authors etc is missing as well, but I fetched them from the actual source 
file.

e) the autoconf/automake requires of libnxcl are extremely high, while it 
seems to build just fine with older version of autotools, once those are 
fixed. Is there a reason for that? this is a problem for older distributions.


Greetings,
Dirk

["nxcl-docdir.diff" (text/x-diff)]

--- nxcl/doc/Makefile.am
+++ nxcl/doc/Makefile.am
@@ -2,8 +2,6 @@ CLEANFILES = *~
 
 DOXYFILE = Doxyfile
 
-docdir = $(prefix)/doc/$(PACKAGE)-$(VERSION)
-
 EXTRA_DIST = html
 
 SEDCMD1 = s/$$title/GNU nxcl documentation version $(VERSION)/g

["gcc-4.3.diff" (text/x-diff)]

--- nxcl/lib/notQt.cpp
+++ nxcl/lib/notQt.cpp
@@ -28,6 +28,7 @@ extern "C" {
 #include <sys/poll.h>	
 #include <signal.h>
 }
+#include <stdlib.h>
 
 #include "../config.h"
 #include "notQt.h"
--- nxcl/lib/nxclientlib.cpp
+++ nxcl/lib/nxclientlib.cpp
@@ -34,6 +34,8 @@ extern "C" {
     #include <sys/stat.h>
     #include <unistd.h>
 }
+#include <stdlib.h>
+#include <string.h>
 
 /*
  * On the location of nxproxy and nxssh binaries
--- nxcl/nxcl/nxcl.cpp
+++ nxcl/nxcl/nxcl.cpp
@@ -30,6 +30,7 @@ extern "C" {
 #include <dbus/dbus.h>
 #include <X11/Xlib.h>
 }
+#include <stdlib.h>
 
 using namespace nxcl;
 using namespace std;

["qtnx-install.diff" (text/x-diff)]

--- qtnx/qtnx.pro
+++ qtnx/qtnx.pro
@@ -27,3 +27,5 @@ DEPENDPATH	+= $(QTDIR)/include
 QT += ui xml
 
 TARGET		= qtnx
+target.path = $$[QT_INSTALL_BINS]
+INSTALLS += target


________________________________________________________________
     Were you helped on this list with your FreeNX problem?
    Then please write up the solution in the FreeNX Wiki/FAQ:
  http://openfacts.berlios.de/index-en.phtml?title=FreeNX_FAQ
         Don't forget to check the NX Knowledge Base:
                 http://www.nomachine.com/kb/ 

________________________________________________________________
       FreeNX-kNX mailing list --- FreeNX-kNX@kde.org
      https://mail.kde.org/mailman/listinfo/freenx-knx
________________________________________________________________

[prev in list] [next in list] [prev in thread] [next in thread]