[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg-devel
Subject:    Re: [PATCH xserver 0/3] Use DRM GetFB2 ioctl
From:       Adam Jackson <ajax () nwnk ! net>
Date:       2018-03-28 18:55:10
Message-ID: 7c2ae946af127180cd48517aaff629bcd9634c23.camel () nwnk ! net
[Download RAW message or body]

On Fri, 2018-03-23 at 13:50 +0000, Daniel Stone wrote:
> Hi,
> This short patchset makes modesetting use the shiny, new, and completely
> not at all merged GetFB2 DRM ioctl:
> https://lists.freedesktop.org/archives/dri-devel/2018-March/170512.html
> 
> When starting Xorg with -background none, it uses GetFB to interrogate
> the current framebuffer, importing it into a Glamor texture so it can
> copy back to its own storage. Unfortunately, if your buffer was
> multi-planar (e.g. new Intel with auxiliary compression buffer), or just
> too exotic to be described without a modifier (etnaviv in tiled mode),
> GetFB fell short of what we actually needed.
> 
> GetFB2 is the equivalent to AddFB2 (or AddFB2WithModifiers; both the
> same from an ioctl point of view), so this ports modesetting to use that
> where available and use with more complex buffers.
> 
> The kernel ABI rules require positive review from real userspace (not
> random hacked-up libdrm tests) before merging. Given that, I'd
> appreciate someone taking a look at the use of GetFB2 here, and
> following up with a statement that they think the ABI is actually good
> and long-term usable for what Xorg needs. (Or, well, some kind of
> constructive criticism.)

ABI looks plausible to me. I've merged 1/3 as it's obviously good:

remote: I: patch #212502 updated using rev 7004a7c3c983b4453756b92341bf22790b1eb98d.
remote: I: 1 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/xserver
   be087778a0..7004a7c3c9  master -> master

- ajax
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
[prev in list] [next in list] [prev in thread] [next in thread]