[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg-devel
Subject:    Re: [PATCH util-modular] release.sh: run autogen.sh instead of manual autoreconf + configure
From:       Sergey Udaltsov <sergey.udaltsov () gmail ! com>
Date:       2017-02-01 1:43:08
Message-ID: CAHiMruMruJ1-EwEJ8RXq+W_UTSVJP2uFu=_ANNWa=ZCiaRxHRg () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Thank you Peter! Worked just great!

On Wed, Feb 1, 2017 at 12:58 AM, Peter Hutterer <peter.hutterer@who-t.net>
wrote:

> xkeyboard-config needs extra env variables to be set during autoreconf and
> that is handled in the autogen.sh script. If we invoke autoreconf
> directly, we
> fail on this repo.
>
> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
> ---
> Sending this out so Sergey can use it now, I haven't tested this on all
> repos yet. But I think we have an autogen.sh everywhere anyway, so I don't
> expect that to fail.
>
>  release.sh | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/release.sh b/release.sh
> index e0209bc..c894063 100755
> --- a/release.sh
> +++ b/release.sh
> @@ -384,14 +384,8 @@ process_module() {
>         return 1
>      fi
>
> -    echo "Info: generating configure."
> -    autoreconf --force --install >/dev/null
> -    if [ $? -ne 0 ]; then
> -        echo "Error: failed to generate configure."
> -        return 1
> -    fi
> -
> -    ./configure >/dev/null
> +    echo "Info: running autogen.sh"
> +    ./autogen.sh >/dev/null
>      if [ $? -ne 0 ]; then
>          echo "Error: failed to configure module."
>          cd $top_src
> --
> 2.9.3
>
>

[Attachment #5 (text/html)]

<div dir="ltr">Thank you Peter! Worked just great!<br></div><div \
class="gmail_extra"><br><div class="gmail_quote">On Wed, Feb 1, 2017 at 12:58 AM, \
Peter Hutterer <span dir="ltr">&lt;<a href="mailto:peter.hutterer@who-t.net" \
target="_blank">peter.hutterer@who-t.net</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">xkeyboard-config needs extra env variables to be set during \
autoreconf and<br> that is handled in the autogen.sh script. If we invoke autoreconf \
directly, we<br> fail on this repo.<br>
<br>
Signed-off-by: Peter Hutterer &lt;<a \
                href="mailto:peter.hutterer@who-t.net">peter.hutterer@who-t.net</a>&gt;<br>
                
---<br>
Sending this out so Sergey can use it now, I haven&#39;t tested this on all<br>
repos yet. But I think we have an autogen.sh everywhere anyway, so I don&#39;t<br>
expect that to fail.<br>
<br>
  release.sh | 10 ++--------<br>
  1 file changed, 2 insertions(+), 8 deletions(-)<br>
<br>
diff --git a/release.sh b/release.sh<br>
index e0209bc..c894063 100755<br>
--- a/release.sh<br>
+++ b/release.sh<br>
@@ -384,14 +384,8 @@ process_module() {<br>
            return 1<br>
        fi<br>
<br>
-      echo &quot;Info: generating configure.&quot;<br>
-      autoreconf --force --install &gt;/dev/null<br>
-      if [ $? -ne 0 ]; then<br>
-            echo &quot;Error: failed to generate configure.&quot;<br>
-            return 1<br>
-      fi<br>
-<br>
-      ./configure &gt;/dev/null<br>
+      echo &quot;Info: running autogen.sh&quot;<br>
+      ./autogen.sh &gt;/dev/null<br>
        if [ $? -ne 0 ]; then<br>
              echo &quot;Error: failed to configure module.&quot;<br>
              cd $top_src<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.9.3<br>
<br>
</font></span></blockquote></div><br></div>


[Attachment #6 (text/plain)]

_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[prev in list] [next in list] [prev in thread] [next in thread]