[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg-devel
Subject:    Re: [PATCH xts v2] xts5: Fix clang error - non-void function 'outfile' should return a value
From:       Peter Hutterer <peter.hutterer () who-t ! net>
Date:       2016-11-25 3:13:59
Message-ID: 20161125031359.GA21331 () jelly
[Download RAW message or body]

On Thu, Nov 24, 2016 at 09:54:14PM -0500, Rhys Kidd wrote:
> files.c:267:3: error: non-void function 'outfile' should return a value
>       [-Wreturn-type]
>                 return;
>                 ^
> 
> v2: Correct declaration (Peter Hutterer)

thanks, pushed

   1a7eea0..6f2e907  master -> master

Cheers,
  Peter

> ---
>  xts5/src/bin/mc/files.c   | 2 +-
>  xts5/src/bin/mc/mcproto.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/xts5/src/bin/mc/files.c b/xts5/src/bin/mc/files.c
> index ee88a40..a9198e1 100644
> --- a/xts5/src/bin/mc/files.c
> +++ b/xts5/src/bin/mc/files.c
> @@ -236,7 +236,7 @@ char *tmpfile;
>   * Combine all the files in the right order onto
>   * stdout.
>   */
> -outfile(fp)
> +void outfile(fp)
>  FILE	*fp;
>  {
>  static FILE	*fout;
> diff --git a/xts5/src/bin/mc/mcproto.h b/xts5/src/bin/mc/mcproto.h
> index 32dd711..16df294 100644
> --- a/xts5/src/bin/mc/mcproto.h
> +++ b/xts5/src/bin/mc/mcproto.h
> @@ -105,7 +105,7 @@ void mepcomment(char *buf);
>  FILE *nextfile(struct mclist *sources);
>  void outcopy(char *file);
>  FILE *cretmpfile(char *file, char **crefile);
> -int outfile(FILE *fp);
> +void outfile(FILE *fp);
>  int remfiles(void);
>  int includefile(char *file, char *bp);
>  void filetemp(char *name);
> -- 
> 2.9.3
> 
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
[prev in list] [next in list] [prev in thread] [next in thread]