[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg-devel
Subject:    Re: [PATCH xserver] glamor: don't look for non-existing EGL_KHR_platform_base
From:       Adam Jackson <ajax () redhat ! com>
Date:       2016-10-25 21:00:44
Message-ID: 1477429244.29084.27.camel () redhat ! com
[Download RAW message or body]

On Fri, 2016-10-21 at 19:06 +0100, Emil Velikov wrote:
> > From: Emil Velikov <emil.velikov@collabora.com>
> 
> The extensions does not exist in the registry, thus needs to know
> they're using EGL 1.5 in order to determine the eglGetPlatformDisplay
> function pointer is valid.
> 
> Thus brings us into some lovely circular dependency.

Ugh.  Right you are, I seem to have gotten a bit optimistic by seeing
other EGL_KHR_platform_* extensions.

> In practise (checked with the Mali driver) any EGL 1.5 driver will
> advertise support for EGL_EXT_platform_base.

Yeah, I think this pretty much has to be true. The whole point of the
platform  extensions is that you have to use them _before_ you have an
EGL context, meaning you can't know if you're EGL 1.5 ahead of time.
It's kinda lame that 1.5 doesn't have a mandatory extension string for
this (since the KHR entrypoints really do have a different signature)
but that's Khronos' bug not Xorg's.

Merged, thanks:

remote: I: patch #117260 updated using rev 7fc96fb02dade4a86f2fc038f3cf5f2d9c0cda00.
remote: I: 1 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/xserver
   5dcb066..7fc96fb  master -> master

- ajax
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
[prev in list] [next in list] [prev in thread] [next in thread]