[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg-devel
Subject:    Re: [PATCH 14/14] os: Fix -Wshadow warnings
From:       Keith Packard <keithp () keithp ! com>
Date:       2013-12-29 23:49:12
Message-ID: 86iou76ww7.fsf () miki ! keithp ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

Content-Transfer-Encoding: quoted-printable

Adam Jackson <ajax@redhat.com> writes:

> Signed-off-by: Adam Jackson <ajax@redhat.com>

>  static XdmClientAuthPtr
>  XdmAuthorizationValidate(unsigned char *plain, int length,
> -                         XdmAuthKeyPtr rho, ClientPtr xclient,
> +                         XdmAuthKeyPtr _rho, ClientPtr xclient,
>                           const char **reason)
>  {

I made the global one 'global_rho' instead of changing the local rho
names.


>  static void
>  XdmcpSelectHost(const struct sockaddr *host_sockaddr,
> -                int host_len, ARRAY8Ptr AuthenticationName)
> +                int host_len, ARRAY8Ptr authname)

auth_name instead?

Reviewed-by: Keith Packard <keithp@keithp.com>

-- 
keith.packard@intel.com

[Attachment #5 (application/pgp-signature)]

_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

[prev in list] [next in list] [prev in thread] [next in thread]