From freedesktop-xorg-devel Wed Aug 28 15:36:26 2013 From: Pino Toscano Date: Wed, 28 Aug 2013 15:36:26 +0000 To: freedesktop-xorg-devel Subject: [PATCHES] fix build on GNU/Hurd with GCC 4.8 Message-Id: <2141977.O19ZSyXSQ0 () drak> X-MARC-Message: https://marc.info/?l=freedesktop-xorg-devel&m=137770872810011 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0003531057==" --===============0003531057== Content-Type: multipart/signed; boundary="nextPart1514987.b1lFJhDVWq"; micalg="pgp-sha1"; protocol="application/pgp-signature" --nextPart1514987.b1lFJhDVWq Content-Type: multipart/mixed; boundary="nextPart2778042.CqDXPAt9FJ" Content-Transfer-Encoding: 7Bit This is a multi-part message in MIME format. --nextPart2778042.CqDXPAt9FJ Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Hi, (please CC me, as I am not subscribed) with GCC 4.8, few "implicit declaration of function" warnings become errors, breaking the build of xserver on the Hurd. Attached there are two patches, which apply fine in both master and server-1.14-branch branches, which fix the errors providing the right includes: * the inclusion of in Hurd parts should be straightforward * the move of the (which is POSIX) to a move general location affects any other Unix system with IPv6 support, I hope it is not a problem for all the supported platforms Thanks, -- Pino Toscano --nextPart2778042.CqDXPAt9FJ Content-Disposition: attachment; filename="0001-xfree86-hurd-include-hurd.h.patch" Content-Transfer-Encoding: 7Bit Content-Type: text/x-patch; charset="UTF-8"; name="0001-xfree86-hurd-include-hurd.h.patch" From ef6a236cf9b795017c9c8c4447a6735fa04bb061 Mon Sep 17 00:00:00 2001 From: Pino Toscano Date: Wed, 28 Aug 2013 17:04:48 +0200 Subject: [PATCH] xfree86/hurd: include Needed for using get_privileged_port. Signed-off-by: Pino Toscano --- hw/xfree86/os-support/hurd/hurd_init.c | 1 + hw/xfree86/os-support/hurd/hurd_mmap.c | 1 + hw/xfree86/os-support/hurd/hurd_video.c | 1 + 3 files changed, 3 insertions(+) diff --git a/hw/xfree86/os-support/hurd/hurd_init.c b/hw/xfree86/os-support/hurd/hurd_init.c index 185b2b9..fe1a764 100644 --- a/hw/xfree86/os-support/hurd/hurd_init.c +++ b/hw/xfree86/os-support/hurd/hurd_init.c @@ -42,6 +42,7 @@ #include #include #include +#include int xf86ProcessArgument(int argc, char **argv, int i) diff --git a/hw/xfree86/os-support/hurd/hurd_mmap.c b/hw/xfree86/os-support/hurd/hurd_mmap.c index 6ac9efd..8e089ca 100644 --- a/hw/xfree86/os-support/hurd/hurd_mmap.c +++ b/hw/xfree86/os-support/hurd/hurd_mmap.c @@ -27,6 +27,7 @@ #include #include #include +#include #include diff --git a/hw/xfree86/os-support/hurd/hurd_video.c b/hw/xfree86/os-support/hurd/hurd_video.c index 72474ba..b3b94c9 100644 --- a/hw/xfree86/os-support/hurd/hurd_video.c +++ b/hw/xfree86/os-support/hurd/hurd_video.c @@ -28,6 +28,7 @@ #include #include #include +#include #include #include "input.h" -- 1.7.10.4 --nextPart2778042.CqDXPAt9FJ Content-Disposition: attachment; filename="0002-os-move-arpa-inet.h-for-any-win32-system.patch" Content-Transfer-Encoding: 7Bit Content-Type: text/x-patch; charset="UTF-8"; name="0002-os-move-arpa-inet.h-for-any-win32-system.patch" From 006b123a801afab44a9e1a3d6e2ff5e1c6415362 Mon Sep 17 00:00:00 2001 From: Pino Toscano Date: Wed, 28 Aug 2013 17:15:03 +0200 Subject: [PATCH] os: move for any !win32 system It is needed in IPv6 configurations (for inet_pton) also when SIOCGIFCONF is not defined. Signed-off-by: Pino Toscano --- os/access.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/os/access.c b/os/access.c index 88a44d9..6d991b3 100644 --- a/os/access.c +++ b/os/access.c @@ -163,6 +163,10 @@ SOFTWARE. /* #endif */ #endif +#if defined(IPv6) && defined(AF_INET6) +#include +#endif + #endif /* WIN32 */ #define X_INCLUDE_NETDB_H @@ -461,10 +465,6 @@ DefineSelf(int fd) #endif #if defined(IPv6) && defined(AF_INET6) -#include -#endif - -#if defined(IPv6) && defined(AF_INET6) static void in6_fillscopeid(struct sockaddr_in6 *sin6) { -- 1.7.10.4 --nextPart2778042.CqDXPAt9FJ-- --nextPart1514987.b1lFJhDVWq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) iD8DBQBSHhkATNH2piB/L3oRArtkAKC9hhQ54PidxW4+/iviyxdRjnLK6ACeMLBo 2u4UUqxTKMDWLsypFddd4lA= =MBxb -----END PGP SIGNATURE----- --nextPart1514987.b1lFJhDVWq-- --===============0003531057== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel --===============0003531057==--