[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg-devel
Subject:    Re: [PATCH] Use external tool for creating backtraces on crashes if
From:       Barry Scott <barry.scott () onelan ! co ! uk>
Date:       2010-12-07 17:42:06
Message-ID: 201012071742.06587.barry.scott () onelan ! co ! uk
[Download RAW message or body]

On Friday 08 October 2010 17:25:12 Matthias Hopf wrote:
> This calls /usr/bin/xorg-backtrace to create reasonable commented backtraces
> with gdb. On errors it falls back to the generic method.
> 
> Signed-off-by: Matthias Hopf <mhopf@suse.de>
> ---

This is a very useful patch, thanks for developing it.

...

> +    status = 0;
> +    while (fgets (buf, 256, f)) {
> +	status++;
> +	ErrorF("%s", buf);
> +    }
> +    fclose (f);
> +    if (status < 10 && ret == 0) {
> +	ErrorF ("%s only produced %d lines of output\n", xorg_backtrace, status);
> +	return 1;
> +    }


We are using this patch with a different usage. In our environment the stdout
file from Xorg does not last long enough, its gone after the user reboots.

Our xorg-backtrace script writes the analysis into a new log file.

It would match our usage better to have this check for atleast 1 line rather
then 10. Our one line says where we wrote the analysis too.

Barry
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
[prev in list] [next in list] [prev in thread] [next in thread]