[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg-devel
Subject:    Re: [PULL] Bugzilla triage, take two
From:       Corbin Simpson <mostawesomedude () gmail ! com>
Date:       2010-03-29 18:57:50
Message-ID: e7bd23c31003291157r58396aaaxccc93242accbe7fe () mail ! gmail ! com
[Download RAW message or body]

On Mon, Mar 29, 2010 at 11:54 AM, Keith Packard <keithp@keithp.com> wrote:
> On Fri, 26 Mar 2010 15:10:49 -0700, Corbin Simpson <mostawesomedude@gmail.com> wrote:
>
>> Corbin Simpson (1):
>>       dix: Fix a small potential memory leak in ProcRotateProperties. (#25216)
>
> No. ProcRotateProperties already frees props and saved in the out:
> path. For reviewers -- please look at the code and not just the patch;
> this patch looks 'obviously' correct until you see the surrounding code.

Okay, will NAK the bug.

>> Evgeny M. Zubok (1):
>>       xfree86: Change VBE version early-out to 1.2. (#22672)
>
> Please just post individual patches when they're small and independent
> like this. I don't want to cherry-pick patches.

Okay, will do that next time.

Thanks for putting up with me!
~ C.

-- 
When the facts change, I change my mind. What do you do, sir? ~ Keynes

Corbin Simpson
<MostAwesomeDude@gmail.com>
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

[prev in list] [next in list] [prev in thread] [next in thread]