[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg-devel
Subject:    [PATCH libXext] Don't export xgeExtRegister
From:       jcristau () debian ! org (Julien Cristau)
Date:       2009-11-29 23:10:37
Message-ID: 20091129231037.GH3522 () radis ! liafa ! jussieu ! fr
[Download RAW message or body]

On Mon, Nov 30, 2009 at 08:56:58 +1000, Peter Hutterer wrote:

> xgeExtRegister is defined here but declared in extutil.c.
> 
> the gcc docs recommend adding attributes to the declaration:
> "The visibility attribute should be applied only to declarations which would
> otherwise have external linkage. [...]"
> http://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html#Function-Attributes
> 
> I think it'd be better to move the attribute to extutil.c then. given that
> change,
> Acked-by: Peter Hutterer <peter.hutterer at who-t.net>
> 
I've made that change and pushed.  Thanks.

Cheers,
Julien

[prev in list] [next in list] [prev in thread] [next in thread]