'=?utf-8?B?WDExIENvbG9yIE1hcCBjcmVhdGlvbiBwcm9ibGVtLCBYQWxsb2NDb2xvckNlbGxzIGNhbGwgdGhyb3cgQmFkVmFsdW'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg
Subject:    =?utf-8?B?WDExIENvbG9yIE1hcCBjcmVhdGlvbiBwcm9ibGVtLCBYQWxsb2NDb2xvckNlbGxzIGNhbGwgdGhyb3cgQmFkVmFsdW
From:       "Subrata Dasgupta" <subrata_usha () rediffmail ! com>
Date:       2017-04-10 9:48:48
Message-ID: 20170410094848.20602.qmail () f5mail-224-105 ! rediffmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

Hello All,
I have an 32 bit X11 application running on RHEL 7 and use libX11-1.6.3-2.el7.i686 \
rpm X11 library. This application is facing problem while creating its own color map. \
Please suggest what changes need to be made in the following code to make it \
workable.

This X11 application is getting BadValue error while calling XAllocColorCells \
function when I run the application from VNC. But it is working properly on Citrix. \
Application tries to create a new color map by calling XCreateColormap.

From the gdb debugging I can see two major difference in Xlibrary call behavior \
between VNC and Citrix.

1> XDisplayCells return values are different . on VNC XDisplayCells returns 64 but on \
Citrix client it return 256.

2> On VNC the XCreateColormap call is returning a bigger color map ID (compared with \
Citrix client) which maybe out of range and so bad value error occur. For VNC \
XCreateColormap return 37748737 but for Citrix it return 8388609.

I am not sure how to use Xlibrary to create color map for different X clients. Please \
help.

Below is the high level code of the color map creation…

void createColormap(Display *display)
{
int i, n, snr, coffset, ncolors;
Display *dnr;
XColor dcolors[256];
Window win;
Colormap colormap0, colormap1;
Visual *vis;

win = DefaultRootWindow(display);
ncolors = XDisplayCells(display, DefaultScreen(display));   // Return 64 on VNC , and \
256 for Citrix. dnr = display;
snr = XDefaultScreen(display);
colormap0 = DefaultColormap(dnr,snr);
colormap = colormap0;

if(ncolors > 256) {
return;
}
if(ncolors > 2) {

vis = XDefaultVisual(dnr, XDefaultScreen(dnr));
if(vis == NULL) {
return;
}

//----------------------------------------- portion between this dotted lines do not \
execute on VNC as ncolors =64 and thus coffset =0 \
-------------------------------------------------------- // if(ncolors > 16) {
if(ncolors > 128) {
coffset = 32;
} else {
coffset = 0;
}
} else {
coffset = 0;
}
if(coffset > ncolors) {
coffset = 0;
}
n = ncolors - coffset;

for(i=0; i dcolors[i].pixel = i;
XQueryColor(dnr, colormap0, &(dcolors[i]));
dcolors[i].flags = DoRed | DoGreen | DoBlue;
}
//----------------------------------------- portion between this dotted lines do not \
execute on VNC as ncolors =64 and thus coffset =0 \
-------------------------------------------------------- //

colormap1 = XCreateColormap(dnr, win, vis, AllocNone); // This line execute on both. \
Returns 37748737 for VNC but 8388609 Citrix. if(colormap1 == colormap) {
return;
}

//============================ portion between this dotted lines do not execute on \
VNC as ncolors < 256 and coffset < 128 ========================== // if(ncolors >= \
256 && coffset < 128) { int r, g, b;
for(r=0; r < 4; r++) {
for(g=0; g < 4; g++) {
for(b=0; b < 4; b++) {
dcolors[coffset].pixel = coffset;
dcolors[coffset].flags = DoRed | DoGreen | DoBlue;
dcolors[coffset].red = (short) (r * 21845);
dcolors[coffset].green = (short) (g * 21845);
dcolors[coffset].blue = (short) (b * 21845);
coffset++;
if(coffset >= 256) break;
}
if(coffset >= 256) break;
}
if(coffset >= 256) break;
}
}
//============================ portion between this dotted lines do not execute on \
VNC as ncolors < 256 and coffset < 128 ========================== //

unsigned long plane_masks_return[1];
unsigned int nplanes= 0;
unsigned long pixels_return[256];
unsigned int npixels = coffset;
int status;
status = XAllocColorCells(dnr, colormap1, True, plane_masks_return, nplanes, \
pixels_return, npixels); //this call throw BadValue error. if(status == 0) {
return;
} else {
XStoreColors(dnr, colormap1, &(dcolors[0]), coffset);
colormap = colormap1;
}
}
}

Thanks
Subrata

[Attachment #5 (unknown)]

Hello All,<br />
I have an 32 bit X11 application running on RHEL 7 and use libX11-1.6.3-2.el7.i686 \
rpm X11 library. This application is facing problem while creating its own color map. \
Please suggest what changes need to be made in the following code to make it \
workable.<br /> <br />
This X11 application is getting BadValue error while calling XAllocColorCells \
function when I run the application from VNC. But it is working properly on Citrix. \
Application tries to create a new color map by calling XCreateColormap.<br /> <br />
From the gdb debugging I can see two major difference in Xlibrary call behavior \
between VNC and Citrix.<br /> <br />
1> XDisplayCells return values are different . on VNC XDisplayCells returns 64 but on \
Citrix client it return 256.<br /> <br />
2> On VNC the XCreateColormap call is returning a bigger color map ID (compared with \
Citrix client) which maybe out of range and so bad value error occur.<br /> For VNC \
XCreateColormap return 37748737 but for Citrix it return 8388609.<br /> <br />
I am not sure how to use Xlibrary to create color map for different X clients. Please \
help.<br /> <br />
Below is the high level code of the color map creation…<br />
<br />
void createColormap(Display *display)<br />
{<br />
int i, n, snr, coffset, ncolors;<br />
Display *dnr;<br />
XColor dcolors[256];<br />
Window win;<br />
Colormap colormap0, colormap1;<br />
Visual *vis;<br />
<br />
win = DefaultRootWindow(display);<br />
ncolors = XDisplayCells(display, DefaultScreen(display));   // Return 64 on VNC , and \
256 for Citrix.<br /> dnr = display;<br />
snr = XDefaultScreen(display);<br />
colormap0 = DefaultColormap(dnr,snr);<br />
colormap = colormap0;<br />
<br />
if(ncolors > 256) {<br />
return;<br />
}<br />
if(ncolors > 2) {<br />
<br />
vis = XDefaultVisual(dnr, XDefaultScreen(dnr));<br />
if(vis == NULL) {<br />
return;<br />
}<br />
<br />
//----------------------------------------- portion between this dotted lines do not \
execute on VNC as ncolors =64 and thus coffset =0 \
-------------------------------------------------------- //<br /> if(ncolors > 16) \
{<br /> if(ncolors > 128) {<br />
coffset = 32;<br />
} else {<br />
coffset = 0;<br />
}<br />
} else {<br />
coffset = 0;<br />
}<br />
if(coffset > ncolors) {<br />
coffset = 0;<br />
}<br />
n = ncolors - coffset;<br />
<br />
for(i=0; i dcolors[i].pixel = i;<br />
XQueryColor(dnr, colormap0, &(dcolors[i]));<br />
dcolors[i].flags = DoRed | DoGreen | DoBlue;<br />
}<br />
//----------------------------------------- portion between this dotted lines do not \
execute on VNC as ncolors =64 and thus coffset =0 \
-------------------------------------------------------- //<br /> <br />
<br />
colormap1 = XCreateColormap(dnr, win, vis, AllocNone); // This line execute on both. \
Returns 37748737 for VNC but 8388609 Citrix.<br /> if(colormap1 == colormap) {<br />
return;<br />
}<br />
<br />
//============================ portion between this dotted lines do not execute on \
VNC as ncolors < 256 and coffset < 128 ========================== //<br /> if(ncolors \
>= 256 && coffset < 128) {<br /> int r, g, b;<br />
for(r=0; r < 4; r++) {<br />
for(g=0; g < 4; g++) {<br />
for(b=0; b < 4; b++) {<br />
dcolors[coffset].pixel = coffset;<br />
dcolors[coffset].flags = DoRed | DoGreen | DoBlue;<br />
dcolors[coffset].red = (short) (r * 21845);<br />
dcolors[coffset].green = (short) (g * 21845);<br />
dcolors[coffset].blue = (short) (b * 21845);<br />
coffset++;<br />
if(coffset >= 256) break;<br />
}<br />
if(coffset >= 256) break;<br />
}<br />
if(coffset >= 256) break;<br />
}<br />
}<br />
//============================ portion between this dotted lines do not execute on \
VNC as ncolors < 256 and coffset < 128 ========================== //<br /> <br />
unsigned long plane_masks_return[1];<br />
unsigned int nplanes= 0;<br />
unsigned long pixels_return[256];<br />
unsigned int npixels = coffset;<br />
int status;<br />
status = XAllocColorCells(dnr, colormap1, True, plane_masks_return, nplanes, \
pixels_return, npixels); //this call throw BadValue error.<br /> if(status == 0) {<br \
/> return;<br />
} else {<br />
XStoreColors(dnr, colormap1, &(dcolors[0]), coffset);<br />
colormap = colormap1;<br />
}<br />
}<br />
}<br />
<br />
Thanks<br />
Subrata<br />
<br>

[Attachment #6 (text/plain)]

_______________________________________________
xorg@lists.x.org: X.Org support
Archives: http://lists.freedesktop.org/archives/xorg
Info: https://lists.x.org/mailman/listinfo/xorg
Your subscription address: %(user_address)s

[prev in list] [next in list] [prev in thread] [next in thread] 