[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg
Subject:    Re: [PATCH] Little fixes for your recent RandR 1.5 additions
From:       Michael Stapelberg <michael () stapelberg ! ch>
Date:       2016-11-26 9:36:38
Message-ID: CANnVG6m=kfp9_WragJ1PqKHLKR7srjBoFGdbVWWiLkAE5nVKww () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


[+cc xorg mailing list]

I never received a reply to this. Were my changes incorrect?

I noticed two more oddities which I could not make sense of while
implementing support for RandR 1.5:
• RRGetMonitors has 6*n+o in its "reply length" member, but later on states
(n*24 + o*4) in the "monitors" member. Which of the two is it?
• MONITORINFO is described as having length (16 + 4*n), but counting the
members I arrive at (24 + 4*n).

On Sun, Jul 26, 2015 at 6:10 PM, Michael Stapelberg <michael@stapelberg.ch>
wrote:

> Hey Keith,
>
> while trying to implement RandR 1.5 in xcb-proto, I've stumbled over a
> couple little inconsistencies with randrproto.txt. Find attached a patch
> which, hopefully, makes things clearer.
>
> I'm sending this directly to you since you're the person with the most
> insight on your own intentions, so you're the best reviewer for the patch,
> I think.
>
> --
> Best regards,
> Michael
>



-- 
Best regards,
Michael

[Attachment #5 (text/html)]

<div dir="ltr">[+cc xorg mailing list]<div><br></div><div>I never received a reply to \
this. Were my changes incorrect?</div><div><br></div><div>I noticed two more oddities \
which I could not make sense of while implementing support for RandR \
1.5:</div><div>•  RRGetMonitors has 6*n+o in its "reply length" member, but later \
on states (n*24 + o*4) in the "monitors" member. Which of the two is \
it?</div><div>• MONITORINFO is described as having length (16 + 4*n), but counting \
the members I arrive at (24 + 4*n).</div></div><div class="gmail_extra"><br><div \
class="gmail_quote">On Sun, Jul 26, 2015 at 6:10 PM, Michael Stapelberg <span \
dir="ltr">&lt;<a href="mailto:michael@stapelberg.ch" \
target="_blank">michael@stapelberg.ch</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr">Hey Keith,<div><br></div><div>while trying to \
implement RandR 1.5 in xcb-proto, I've stumbled over a couple little inconsistencies \
with randrproto.txt. Find attached a patch which, hopefully, makes things \
clearer.</div><div><br></div><div>I'm sending this directly to you since you're the \
person with the most insight on your own intentions, so you're the best reviewer for \
the patch, I think.<span class="HOEnZb"><font color="#888888"><br \
clear="all"><div><br></div>-- <br><div \
class="m_4385067350587825222gmail_signature"><div dir="ltr">Best \
regards,<div>Michael</div></div></div> </font></span></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div \
class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Best \
regards,<div>Michael</div></div></div> </div>


[Attachment #6 (text/plain)]

_______________________________________________
xorg@lists.x.org: X.Org support
Archives: http://lists.freedesktop.org/archives/xorg
Info: https://lists.x.org/mailman/listinfo/xorg
Your subscription address: %(user_address)s

[prev in list] [next in list] [prev in thread] [next in thread]