[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg
Subject:    Re: [PATCH 1/5] build: use AC_CONFIG_MACRO_DIR as per libtoolize
From:       Jeremy Huddleston <jeremyhu () apple ! com>
Date:       2010-11-29 16:50:18
Message-ID: 1BCF6540-B685-4572-AF93-0A3863B1DE80 () apple ! com
[Download RAW message or body]


On Nov 29, 2010, at 09:02, Dan Nicholson wrote:

> On Sun, Nov 28, 2010 at 1:39 PM, Gaetan Nadon <memsize@videotron.ca> wrote:
> > On Sun, 2010-11-28 at 21:26 +0100, Jan Engelhardt wrote:
> > 
> > On Sunday 2010-11-28 19:45, Gaetan Nadon wrote:
> > 
> > > On Sun, 2010-11-28 at 15:46 +0100, Jan Engelhardt wrote:
> > > +ACLOCAL_AMFLAGS = -I m4
> > > 
> > > This will fail if m4 does not exist at clone time.
> > > It won't because there is a .gotognore file in there.
> > > However, it will be suggested later to use the same
> > > toplevel .gitignore file that is used in all other 240 xorg modules.
> > 
> > Then perhaps you need to update the master xorg .gitignore, because the
> > suggestion to use ACLOACL_AMFLAGS will appear on any project with a
> > libtool library.
> > 
> > The suggestion to use ACLOCAL_AMFLAGS come from the Autoconf tools.
> > I looked at the warnings and the output of autoupdate and autoscan and there
> > are plenty of warnings that do not apply.
> 
> Pretty sure it's coming from libtoolize :)
> 
> libtoolize: Consider adding "AC_CONFIG_MACRO_DIR([m4])" to configure.ac and
> libtoolize: rerunning libtoolize, to keep the correct libtool macros in-tree.
> libtoolize: Consider adding "-I m4" to ACLOCAL_AMFLAGS in Makefile.am.
> 
> It's suggesting that you add AC_CONFIG_MACRO_DIR([m4]) so that it will
> helpfully install it's m4 files there and attempt to make them
> persistent. Jeremy Huddleston asked not to do this a while back
> because it's then harder to replace the included libtool with the
> patched version on OSX. Not sure if this is still a problem, but there
> are definitely pros and cons to distributing the libtool macros in the
> tree.

It doesn't have anything to do specifically with OSX.  It's any version of libtool.  \
IIRC, if we ship with glibtool-2.x, that version's macros will be added to the m4 \
directory.  If we then do an 'autoreconf -fvi' in the directory, depending on the \
version of glibtool on the system, it's not deterministic which version of the m4 \
macros will be used (packaged versus system)... but the system's glibtool will always \
be used...


_______________________________________________
xorg@lists.freedesktop.org: X.Org support
Archives: http://lists.freedesktop.org/archives/xorg
Info: http://lists.freedesktop.org/mailman/listinfo/xorg
Your subscription address: freedesktop-xorg@progressive-comp.com


[prev in list] [next in list] [prev in thread] [next in thread]