[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-xorg
Subject:    Re: DRI2 Event BufferSwapComplete too long for core protocol?
From:       Julien Cristau <jcristau () debian ! org>
Date:       2010-11-29 12:23:56
Message-ID: 20101129122355.GG21708 () patate ! is-a-geek ! org
[Download RAW message or body]

On Mon, Nov 29, 2010 at 07:57:16 +0200, Mikko Markus Torni wrote:

> Hi,
> 
> I was updating my local dri2.xml based on the latest dri2proto.h [1]
> and I noticed that the DRI2 event BufferSwapComplete is too long to
> fit core protocol events.
> 
> The best I can calculate is
>     sizeof(xDRI2BufferSwapComplete) == 34

It's actually 36, since there's padding between CARD16 event_type and
CARD32 drawable.

> which disagrees with
>     #define sz_xDRI2BufferSwapComplete 32
> 
> I suppose if event_type would be a CARD8, it could fit where the
> padding is now and the length discrepancy would be fixed.
> 
> Any comments?
> 
Adding Jesse and Kristian to cc...  That sounds like something we need
to fix.

Cheers,
Julien
_______________________________________________
xorg@lists.freedesktop.org: X.Org support
Archives: http://lists.freedesktop.org/archives/xorg
Info: http://lists.freedesktop.org/mailman/listinfo/xorg
Your subscription address: freedesktop-xorg@progressive-comp.com
[prev in list] [next in list] [prev in thread] [next in thread]